From: Andrew Morton <akpm@zip.com.au>
To: glynis@butterfly.hjsoft.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.20: smbfs oops in smb_readpage
Date: Wed, 05 Jun 2002 19:03:18 -0700 [thread overview]
Message-ID: <3CFEC2E6.F1AF17B5@zip.com.au> (raw)
In-Reply-To: <20020606013654.GA32609@butterfly.hjsoft.com>
glynis@butterfly.hjsoft.com wrote:
>
> reading a file from an smbfs causes this oops, then the smbfs won't
> unmount.
> ...
> >>EIP; ccae8013 <[smbfs]smb_readpage+13/40> <=====
>
> >>ebx; c11a2850 <_end+ea2c6c/c5e241c>
> >>ecx; c11a2850 <_end+ea2c6c/c5e241c>
> >>edx; c1049b8c <_end+d49fa8/c5e241c>
> >>edi; c66f3138 <_end+63f3554/c5e241c>
> >>esp; c78a5e44 <_end+75a6260/c5e241c>
>
> Trace; c013bed4 <read_pages+84/a0>
> Trace; c013bfb0 <do_page_cache_readahead+c0/140>
You can blame me for that.
Does this work OK?
--- 2.5.20/mm/readahead.c~readpages Wed Jun 5 18:59:49 2002
+++ 2.5.20-akpm/mm/readahead.c Wed Jun 5 19:00:14 2002
@@ -32,7 +32,7 @@ static inline unsigned long get_min_read
}
static int
-read_pages(struct address_space *mapping,
+read_pages(struct file *file, struct address_space *mapping,
struct list_head *pages, unsigned nr_pages)
{
unsigned page_idx;
@@ -44,7 +44,7 @@ read_pages(struct address_space *mapping
struct page *page = list_entry(pages->prev, struct page, list);
list_del(&page->list);
if (!add_to_page_cache_unique(page, mapping, page->index))
- mapping->a_ops->readpage(NULL, page);
+ mapping->a_ops->readpage(file, page);
page_cache_release(page);
}
return 0;
@@ -167,7 +167,7 @@ void do_page_cache_readahead(struct file
* uptodate then the caller will launch readpage again, and
* will then handle the error.
*/
- read_pages(mapping, &page_pool, nr_to_really_read);
+ read_pages(file, mapping, &page_pool, nr_to_really_read);
blk_run_queues();
BUG_ON(!list_empty(&page_pool));
return;
-
prev parent reply other threads:[~2002-06-06 1:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-06 1:36 2.5.20: smbfs oops in smb_readpage glynis
2002-06-06 2:03 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CFEC2E6.F1AF17B5@zip.com.au \
--to=akpm@zip.com.au \
--cc=glynis@butterfly.hjsoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.