Re: 2.4.19pre10aa1

[Andrew Morton <akpm@zip.com.au>]

Andrea Arcangeli wrote:
> 
> ...
> Only in 2.4.19pre10aa1: 90_ext3-commit-interval-1
> 
>         Avoid laptops to waste energy despite kupdate interval is set
>         to 2 hours with ext3. kjournald has no right to choose
>         "how frequently" we should look for old transactions, that's
>         an user problem. journaling doesn't enforce how much old data
>         we can lose after a 'reboot -f', it only enforces that the
>         metadata or even the data will be coherent after an hard reboot.

Yes, that'll work OK.   It's a wild implementation though.  Why not
just add

int bdflush_min(void)
{
	return bdf_prm.b_un.interval;
}
EXPORT_SYMBOL(bdflush_min);

to fs/buffer.c?

(You forgot to export bdf_prm, btw).

-