From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Thunder from the hill <thunder@ngforever.de>
Cc: Lightweight patch manager <patch@luckynet.dynu.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@transmeta.com>,
Mikael Pettersson <mikpe@csd.uu.se>
Subject: Re: [PATCH][2.5] tulip: change device names
Date: Fri, 07 Jun 2002 14:24:03 -0400 [thread overview]
Message-ID: <3D00FA43.2080809@mandrakesoft.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0206071203580.15675-100000@hawkeye.luckynet.adm>
Thunder from the hill wrote:
>Hi,
>
>On Fri, 7 Jun 2002, Jeff Garzik wrote:
>
>
>>Thanks for the effort, that was a quick turnaround :)
>>
>>But unfortunately the patch is wrong.
>>
>>You need to use an index which counts _tulip_ boards, which implies that
>>the index is local to the driver. Currently the only such counter is
>>board_idx, which is a variable local to tulip_init_one().
>>
>>
>
>Would you suggest
>
>a) setting it in some global struct (tulip_private etc.)?
>
>
Yes, I would add "board_idx" member to struct tulip_private, and
initialize it early in tulip_init_one()
Take care to update the printk's of only those functions which are
actually called from tulip_init_one() before register_netdev(). All
other references are correctly using dev->name. "tulip%d" is only
needed at startup.
Jeff
prev parent reply other threads:[~2002-06-07 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-07 17:42 [PATCH][2.5] tulip: change device names Lightweight patch manager
2002-06-07 17:59 ` Jeff Garzik
2002-06-07 18:06 ` Thunder from the hill
2002-06-07 18:24 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D00FA43.2080809@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
--cc=patch@luckynet.dynu.com \
--cc=thunder@ngforever.de \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.