All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ford <david+cert@blue-labs.org>
To: linux-kernel@vger.kernel.org
Subject: 2.4.19-pre10-ac2, compile warnings/failures
Date: Mon, 10 Jun 2002 17:23:11 -0400	[thread overview]
Message-ID: <3D0518BF.4090404@blue-labs.org> (raw)

cpqphp.h: In function `cpq_get_latch_status':
cpqphp.h:698: warning: concatenation of string literals with 
__FUNCTION__ is deprecated
cpqphp.h: In function `wait_for_ctrl_irq':
cpqphp.h:736: warning: concatenation of string literals with 
__FUNCTION__ is deprecated
cpqphp.h:746: warning: concatenation of string literals with 
__FUNCTION__ is deprecated

cpqphp_nvram.c:163: warning: concatenation of string literals with 
__FUNCTION__ is deprecated

cpqphp_nvram.c:179:17: missing terminating " character
cpqphp_nvram.c: In function `access_EV':
cpqphp_nvram.c:180: parse error before "xorl"
cpqphp_nvram.c:184:28: missing terminating " character

People, please don't do things like:

   spin_lock_irqsave(&int15_lock, flags);
   __asm__ (
      "xorl   %%ebx,%%ebx
      xorl    %%edx,%%edx
      pushf
      push    %%cs
      cli
      call    *%6"

Patches keep going in to fix this.

Please do something like:

   spin_lock_irqsave(&int15_lock, flags);
   __asm__ (
      "xorl   %%ebx,%%ebx  \n"
      "xorl    %%edx,%%edx \n"
      "pushf               \n"
      "push    %%cs        \n"
      "cli                 \n"
      "call    *%6         \n"


i2o_core.c:3393:75: missing terminating " character
         printk(KERN_WARNING "i2o: Could not quiesce %s."  "
            Verify setup on next system power up.\n", c->name); 

Please write it like:

         printk(KERN_WARNING "i2o: Could not quiesce %s."  
            "Verify setup on next system power up.\n", c->name);

-d



             reply	other threads:[~2002-06-10 21:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-10 21:23 David Ford [this message]
2002-06-11  0:59 ` 2.4.19-pre10-ac2, compile warnings/failures Thunder from the hill
2002-06-11  6:03   ` Greg KH
2002-06-11 14:15     ` David Ford
     [not found] <Pine.LNX.4.21.0206101811180.364-100000@inbetween.blorf.net>
2002-06-11  1:22 ` Thunder from the hill
2002-06-11  3:05   ` David Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D0518BF.4090404@blue-labs.org \
    --to=david+cert@blue-labs.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.