From: Dan Malek <dan@embeddededge.com>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Eugene Surovegin <ebs@innocent.com>,
linuxppc-embedded@lists.linuxppc.org
Subject: Re: [PATCH] pci_alloc_consistent in an interrupt context
Date: Thu, 13 Jun 2002 17:47:32 -0400 [thread overview]
Message-ID: <3D0912F4.4020300@embeddededge.com> (raw)
In-Reply-To: 20020613205824.GX13541@opus.bloom.county
Tom Rini wrote:
> It looks okay.
It's not quite right.......
The consistent_alloc() should not always call get_vm_area() with GFP_ATOMIC
set. It should use the 'gfp' that is passed into consistent_alloc().
Normally, you will call consistent_alloc() with GFP_KERNEL, and
interrupt functions must know to call the consistent allocators with GFP_ATOMIC.
> ..... But I don't see (immediatly) why the change to
> pci_alloc_consistent was needed as well.
It was a mistake on my part......when CONFIG_NOT_COHERENT_CACHE is used,
the consisten_alloc() returns the dma_handle, and we have to ensure we
don't do the virt_to_bus later to get it (because it will be wrong once
iopa() is discarded :-)
> But aside from that, it looks good and the next step would be to try and
> get the generic changes into 2.5 (and the 2.4.20-pre1, 2.4.19 is more or
> less frozen, esp for a change like this I suspect).
Good Luck ;-)
-- Dan
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-06-13 21:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-13 19:28 [PATCH] pci_alloc_consistent in an interrupt context Eugene Surovegin
2002-06-13 20:58 ` Tom Rini
2002-06-13 21:47 ` Dan Malek [this message]
2002-06-13 21:56 ` Tom Rini
2002-06-14 0:24 ` David Gibson
2002-06-14 0:38 ` Tom Rini
2002-06-14 0:45 ` David Gibson
2002-06-14 0:51 ` Tom Rini
2002-06-14 5:14 ` David Gibson
2002-06-14 14:59 ` Tom Rini
2002-06-15 6:40 ` David Gibson
2002-06-14 1:25 ` Eugene Surovegin
2002-06-14 1:33 ` David Gibson
2002-06-14 1:57 ` Eugene Surovegin
2002-06-14 2:06 ` David Gibson
2002-06-14 2:15 ` Tom Rini
2002-06-14 3:58 ` David Gibson
2002-06-14 4:42 ` Tom Rini
2002-06-14 2:08 ` Dan Malek
2002-06-14 1:57 ` Dan Malek
2002-06-13 22:23 ` Eugene Surovegin
2002-06-13 23:34 ` Paul Mackerras
2002-06-14 2:17 ` Dan Malek
2002-06-14 2:29 ` Eugene Surovegin
2002-06-13 23:37 ` Paul Mackerras
2002-06-14 2:15 ` Dan Malek
2002-06-14 2:21 ` Eugene Surovegin
2002-06-13 23:07 ` [PATCH] pci_alloc_consistent in an interrupt context, part 2 Eugene Surovegin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D0912F4.4020300@embeddededge.com \
--to=dan@embeddededge.com \
--cc=ebs@innocent.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.