From: Martin Dalecki <dalecki@evision-ventures.com>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Jens Axboe <axboe@suse.de>, Paul Bristow <paul@paulbristow.net>,
Gadi Oxman <gadio@netvision.net.il>,
linux-kernel@vger.kernel.org
Subject: Re: [redone PATCH 2.5.22] simple ide-tape/floppy.c cleanup
Date: Fri, 21 Jun 2002 02:22:31 +0200 [thread overview]
Message-ID: <3D1271C7.40305@evision-ventures.com> (raw)
In-Reply-To: Pine.SOL.4.30.0206202302400.14933-200000@mion.elka.pw.edu.pl
Użytkownik Bartlomiej Zolnierkiewicz napisał:
> redone without controversial bits...
>
> generic ATAPI hit #1 against 2.5.22:
>
> - move generic ATAPI structs from ide/ide-floppy.c
> and ide/ide-tape.c to include/atapi.h
> (this has a nice side effect of making ide-tape
> a bit more endianness aware)
>
> - remove IDEFLOPPY_MIN/MAX() macros, use generic ones
>
> - add #ifndef __LINUX_ATAPI_H_ blabla to atapi.h
> to prevent including it more than once
>
>
> should apply cleanly to 2.5.23
Hi Bartek. Nice to see that you picked up on the idea
of code duplication reduction. I think the solution to
the packet comand declarations problesm will be to
move them over from cdrom.h to linux/scsi.h and just letting
scsi/scsi.h include linux/scsi.h. This should even make
distros still linking to kernle headers from /usr/include
happy and will achieve the goal of unification.
And I agree with Jens that for pragmatic reasons we should
just keep the prefix from cdrom.h - it's there and doesn't hurt
but we need one, so why not stick with it? The plain macros
from scsi.h are too ambigous anyway.
prev parent reply other threads:[~2002-06-24 18:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-19 21:45 [PATCH 2.5.22] simple ide-tape.c and ide-floppy.c cleanup Bartlomiej Zolnierkiewicz
2002-06-20 5:42 ` Jens Axboe
2002-06-20 9:16 ` Martin Dalecki
2002-06-20 9:19 ` Jens Axboe
2002-06-20 9:22 ` Martin Dalecki
2002-06-20 16:37 ` Bartlomiej Zolnierkiewicz
2002-06-20 16:41 ` Martin Dalecki
2002-06-20 16:44 ` Jens Axboe
2002-06-20 16:50 ` Bartlomiej Zolnierkiewicz
2002-06-20 17:26 ` Jens Axboe
2002-06-20 21:05 ` [redone PATCH 2.5.22] simple ide-tape/floppy.c cleanup Bartlomiej Zolnierkiewicz
2002-06-21 0:22 ` Martin Dalecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D1271C7.40305@evision-ventures.com \
--to=dalecki@evision-ventures.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=axboe@suse.de \
--cc=gadio@netvision.net.il \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paulbristow.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.