From: Stephan Brauss <sbrauss@optronic.ch>
To: linux-kernel@vger.kernel.org
Subject: Re: [realtek] System hang with heavy network traffic using rtl8139c
Date: Tue, 25 Jun 2002 08:53:50 +0200 [thread overview]
Message-ID: <3D18137E.B0CCC572@optronic.ch> (raw)
Hello,
maybe I had a similar problem. In my case, the rtl8139 chip reports
a negative buffer size and a following dev_alloc_skb() crashed my system.
The problem was caused by receive buffer overruns that occur if the CPU is not fast
enough to fetch all data. Please check if you see rtl8139-realted kernel messages
during the test.
I reported this problem to the realtek list some time ago, but, as far as I know,
it is not included in the test version 1.18 until know.
Here is my patch of rtl8129_rx():
} else {
/* Malloc up new buffer, compatible with net-2e. */
/* Omit the four octet CRC from the length. */
struct sk_buff *skb;
int pkt_size = rx_size - 4;
+ if(pkt_size<0)
+ {
+ if (tp->msg_level & NETIF_MSG_DRV)
+ printk(KERN_ERR"%s: Impossible packet length.\n",dev->name);
+ tp->stats.rx_dropped++;
+ rtl_hw_start(dev);
+ break;
+ }
+
skb = dev_alloc_skb(pkt_size + 2);
if (skb == NULL) {
Additionally, I think it is a good idea to increase the receive buffer size to the maximum by setting
RX_BUF_LEN_IDX from 2 to 3.
If you read older messages of the realtek list, you can find additional driver changes that are maybe
helpfull for you.
Stephan
reply other threads:[~2002-06-25 6:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D18137E.B0CCC572@optronic.ch \
--to=sbrauss@optronic.ch \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.