All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <haveblue@us.ibm.com>
To: dan carpenter <error27@email.com>
Cc: kernel-janitor-discuss@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: lock_kernel check...
Date: Tue, 09 Jul 2002 10:41:01 -0700	[thread overview]
Message-ID: <3D2B202D.6060602@us.ibm.com> (raw)
In-Reply-To: 20020709172723.18529.qmail@email.com

dan carpenter wrote:
 > Smatch.pm is from the smatch.sf.net scripts page.  Smatch is a
 > really unfinished code checker that I've been working on.  It is
 > based on reading the papers about the Stanford checker.

There was a time when I was thinking about the same thing.  It kept 
scaring me the more I thought about it.

 > Unfortunately, after a night of sleep I realize that my script is
 > broken for 2 reasons. 1)  Smatch.pm is meant to track state changes
 > down different code paths.  But unfortunately it wasn't doing that
 > in this case; it was just going down the code without taking into
 > consideration any if_stmts  etc.  I'm extremely embarassed about
 > that.  Sorry.

Don't be sorry.  The script is smarter than the people who caused the 
errors.  (once again, probably me)

 > 2)  What the Stanford checker does is print an error
 > if one return_stmt is called while the kernel is locked and one is
 > called while the kernel is unlocked.  This seems reasonable.

Could you clarify that a bit?

 > I will fix both mistakes later on this week.  Unfortunately I'm in
 > the process of moving and looking for a job etc so I might not get
 > to it for a bit.


-- 
Dave Hansen
haveblue@us.ibm.com


  reply	other threads:[~2002-07-09 17:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-09 17:27 lock_kernel check dan carpenter
2002-07-09 17:41 ` Dave Hansen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-07-09 18:22 dan carpenter
     [not found] <20020709081059.17951.qmail@email.com>
2002-07-09  9:08 ` Dave Hansen
2002-07-09 10:31   ` Zwane Mwaikambo
2002-07-09 17:04     ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D2B202D.6060602@us.ibm.com \
    --to=haveblue@us.ibm.com \
    --cc=error27@email.com \
    --cc=kernel-janitor-discuss@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.