All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <haveblue@us.ibm.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: zippel@linux-m68k.org, linux-kernel@vger.kernel.org
Subject: [PATCH] AFFS fix return without releasing BKL
Date: Thu, 11 Jul 2002 00:28:15 -0700	[thread overview]
Message-ID: <3D2D338F.109@us.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

Linus,
This was found by Dan Carpenter <error27@email.com>, using an smatch 
script.  Looks to me like like an error caused during all the BKL 
pushing.  1 more coming...

Not tested (Greg, please don't hurt me :p )
-- 
Dave Hansen
haveblue@us.ibm.com

[-- Attachment #2: affs-bkl_ret-2.5.25-0.patch --]
[-- Type: text/plain, Size: 320 bytes --]

--- linux-2.5.25-clean/fs/affs/namei.c	Thu Jun 20 15:53:49 2002
+++ linux/fs/affs/namei.c	Thu Jul 11 00:15:16 2002
@@ -345,8 +345,10 @@
 	lock_kernel();
 
 	/* WTF??? */
-	if (!dentry->d_inode)
+	if (!dentry->d_inode) {
+		unlock_kernel();
 		return -ENOENT;
+	}
 
 	res = affs_remove_header(dentry);
 	unlock_kernel();

             reply	other threads:[~2002-07-11  7:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-11  7:28 Dave Hansen [this message]
2002-07-11 20:44 ` [PATCH] AFFS fix return without releasing BKL Roman Zippel
2002-07-12 19:06   ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D2D338F.109@us.ibm.com \
    --to=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.