From: Andrew Morton <akpm@zip.com.au>
To: Jens Axboe <axboe@suse.de>
Cc: William Lee Irwin III <wli@holomorphy.com>, linux-kernel@vger.kernel.org
Subject: Re: [BUG] loop.c oopses
Date: Tue, 16 Jul 2002 01:52:40 -0700 [thread overview]
Message-ID: <3D33DED8.C5C92C06@zip.com.au> (raw)
In-Reply-To: 20020716083142.GQ811@suse.de
Jens Axboe wrote:
>
> On Tue, Jul 16 2002, Andrew Morton wrote:
> > William Lee Irwin III wrote:
> > >
> > > loop.c oopses when bio_copy() returns NULL. This was encountered while
> > > running dbench 16 on a loopback-mounted reiserfs filesystem.
> >
> > ugh. GFP_NOIO is evil. I guess it's better to add __GFP_HIGH
> > there, but it's not a happy solution.
>
> GFP_NOIO has __GFP_WAIT set, so bio_copy -> bio_alloc -> mempool_alloc
> should never fail. Puzzled.
>
Presumably the loop driver was called from within shrink_cache(),
as PF_MEMALLOC. Those allocations can fail.
That's maybe wrong - if there are a decent number of pages
under writeback then we should be able to just wait it out.
But it gets tricky with the loop driver...
-
next prev parent reply other threads:[~2002-07-16 8:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-16 6:24 [BUG] loop.c oopses William Lee Irwin III
2002-07-16 7:07 ` Andrew Morton
2002-07-16 8:31 ` Jens Axboe
2002-07-16 8:52 ` Andrew Morton [this message]
2002-07-16 8:48 ` Jens Axboe
2002-07-16 9:09 ` Andrew Morton
2002-07-16 8:52 ` William Lee Irwin III
2002-07-16 9:19 ` Andrew Morton
2002-07-16 9:16 ` William Lee Irwin III
2002-07-16 9:21 ` Jens Axboe
2002-07-16 12:49 ` Rik van Riel
2002-07-16 16:36 ` Jens Axboe
2002-07-16 16:49 ` Rik van Riel
2002-07-16 17:09 ` Jens Axboe
2002-07-16 19:42 ` Jari Ruusu
2002-07-16 21:14 ` William Lee Irwin III
2002-07-16 21:36 ` Andrew Morton
2002-07-17 5:40 ` Jens Axboe
2002-07-17 15:31 ` Jari Ruusu
2002-07-20 17:03 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D33DED8.C5C92C06@zip.com.au \
--to=akpm@zip.com.au \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.