From: "H. Peter Anvin" <hpa@zytor.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, viro@math.psu.edu,
trond.myklebust@fys.uio.no,
Matija Nalis <mnalis-umsdos@voyager.hr>,
aia21@cantab.net, al@alarsen.net, asun@cobaltnet.com,
bfennema@falcon.csc.calpoly.edu, dave@trylinux.com,
braam@clusterfs.com, chaffee@cs.berkeley.edu,
dwmw2@infradead.org, eric@andante.org, hch@infradead.org,
jaharkes@cs.cmu.edu, jakub@redhat.com, jffs-dev@axis.com,
mikulas@artax.karlin.mff.cuni.cz, quinlan@transmeta.com,
reiserfs-dev@namesys.com, Chris Mason <mason@suse.com>,
rgooch@atnf.csiro.au, rmk@arm.linux.org.uk,
shaggy@austin.ibm.com, tigran@veritas.com, urban@teststation.com,
vandrove@vc.cvut.cz, vl@kki.org, zippel@linux-m68k.org,
Art Haas <ahaas@neosoft.com>
Subject: Re: Remain Calm: Designated initializer patches for 2.5
Date: Wed, 17 Jul 2002 23:32:35 -0700 [thread overview]
Message-ID: <3D366103.8010403@zytor.com> (raw)
In-Reply-To: 20020718032331.5A36644A8@lists.samba.org
Rusty Russell wrote:
> Hi all,
>
> I just sent about 40 reasonable-size patches through the
> Trivial Patch Monkey to Linus: these patches replace the (deprecated)
> "foo: " designated initializers with the ISO-C ".foo =" initializers.
> GCC has understood both since forever, but the kernel took a wrong
> bet, and we're better off setting a good example for 2.6 before we
> start getting about 10,000 warnings.
>
> So far, Art Haas has done all the fs code, and will presumably
> be working through the other code on dir at a time.
>
As far as I could tell, *ALL* of these changes broke text alignment in
columns. It would have been a lot better if they had maintained
spacing; I find the new code much more cluttered and hard to read.
-hpa
next prev parent reply other threads:[~2002-07-18 6:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-18 3:22 Remain Calm: Designated initializer patches for 2.5 Rusty Russell
2002-07-18 3:32 ` Arnaldo Carvalho de Melo
2002-07-18 7:42 ` Rusty Russell
2002-07-18 6:32 ` H. Peter Anvin [this message]
2002-07-18 6:28 ` David S. Miller
2002-07-18 6:40 ` H. Peter Anvin
2002-07-18 6:53 ` Arnaldo Carvalho de Melo
2002-07-18 6:56 ` H. Peter Anvin
2002-07-18 7:33 ` Anton Altaparmakov
2002-07-18 7:46 ` Rusty Russell
2002-07-18 9:34 ` H. Peter Anvin
2002-07-18 13:47 ` Daniel Phillips
2002-07-19 1:32 ` Rusty Russell
2002-07-19 7:31 ` Marcin Dalecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D366103.8010403@zytor.com \
--to=hpa@zytor.com \
--cc=ahaas@neosoft.com \
--cc=aia21@cantab.net \
--cc=al@alarsen.net \
--cc=asun@cobaltnet.com \
--cc=bfennema@falcon.csc.calpoly.edu \
--cc=braam@clusterfs.com \
--cc=chaffee@cs.berkeley.edu \
--cc=dave@trylinux.com \
--cc=dwmw2@infradead.org \
--cc=eric@andante.org \
--cc=hch@infradead.org \
--cc=jaharkes@cs.cmu.edu \
--cc=jakub@redhat.com \
--cc=jffs-dev@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=mnalis-umsdos@voyager.hr \
--cc=quinlan@transmeta.com \
--cc=reiserfs-dev@namesys.com \
--cc=rgooch@atnf.csiro.au \
--cc=rmk@arm.linux.org.uk \
--cc=rusty@rustcorp.com.au \
--cc=shaggy@austin.ibm.com \
--cc=tigran@veritas.com \
--cc=trond.myklebust@fys.uio.no \
--cc=urban@teststation.com \
--cc=vandrove@vc.cvut.cz \
--cc=viro@math.psu.edu \
--cc=vl@kki.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.