From: Dave Hansen <haveblue@us.ibm.com>
To: Robert Love <rml@mvista.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org, Adam G Litke <aglitke@us.ibm.com>
Subject: Re: [PATCH] reduce code in generic spinlock.h
Date: Tue, 23 Jul 2002 09:41:19 -0700 [thread overview]
Message-ID: <3D3D872F.1040100@us.ibm.com> (raw)
In-Reply-To: 1027442320.3581.100.camel@sinai
Robert Love wrote:
> On Tue, 2002-07-23 at 09:28, Dave Hansen wrote:
>
>>The last time lockmeter was ported to 2.5, it was getting a little
>>messy. There were separate declarations for spin_*lock() for each
>>combination of lockmeter and preemption, which made four, plus the
>>no-smp definition. While lockmeter's mess isn't the kernel's fault,
>>we noticed some some simplifications which could be made to the
>>generic spinlock code. This patch uses a single definition for each
>>of the macros, eliminating some redundant code.
>
> I have no problems with this (assuming it is right and it looks so on
> first glance).
>
> It will not apply to Linus's current tree, however, because of the IRQ
> rewrite that is now applied. If you pull his BK tree and diff against
> that, you should be OK... most notably, the preemption code has moved to
> preempt.h.
D'oh. Bad timing, I guess. I'll rediff against current BK.
--
Dave Hansen
haveblue@us.ibm.com
next prev parent reply other threads:[~2002-07-23 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-23 16:28 [PATCH] reduce code in generic spinlock.h Dave Hansen
2002-07-23 16:38 ` Robert Love
2002-07-23 16:41 ` Dave Hansen [this message]
2002-07-23 19:41 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D3D872F.1040100@us.ibm.com \
--to=haveblue@us.ibm.com \
--cc=aglitke@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@mvista.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.