From: Marcin Dalecki <dalecki@evision.ag>
To: Pavel Machek <pavel@ucw.cz>
Cc: vojtech@ucw.cz, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: input: fix sleep support, kill bad ifdefs, cleanup comments
Date: Fri, 26 Jul 2002 02:31:48 +0200 [thread overview]
Message-ID: <3D409874.3050104@evision.ag> (raw)
In-Reply-To: 20020725103713.GA522@elf.ucw.cz
Pavel Machek wrote:
> Hi!
>
> It is possible to kill few #ifdefs from input.c, so I did that.
>
> Comments far to the left hurt readability in my eyes (I believe
> input.c has *way* too much comments, too, but...).
Yes that's Vojtech in action. They don't just hurt my eyes. More
importantly - they interferre with the usage of folding in some editors.
So please consider a style change. (And using FB if console is to narrow
for you. vga=0x318 always worked for me. No GNOME, no KDE, just X11 +
MWM is a good terminal launcher as well - even if rebooting frequently.)
However: Please note that I greatly welcome that Vojtech
actually *does* good commenting in exceptionally *exemplary*
comprehensive and adequate style!
prev parent reply other threads:[~2002-07-26 4:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-25 10:37 input: fix sleep support, kill bad ifdefs, cleanup comments Pavel Machek
2002-07-26 0:31 ` Marcin Dalecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D409874.3050104@evision.ag \
--to=dalecki@evision.ag \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@dalecki.de \
--cc=pavel@ucw.cz \
--cc=vojtech@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.