From: Andrew Morton <akpm@zip.com.au>
To: Rik van Riel <riel@conectiva.com.br>
Cc: William Lee Irwin III <wli@holomorphy.com>, linux-mm@kvack.org
Subject: Re: [PATCH] nru replacement for 2.5.29
Date: Mon, 29 Jul 2002 17:55:28 -0700 [thread overview]
Message-ID: <3D45E400.8E6DC52C@zip.com.au> (raw)
In-Reply-To: Pine.LNX.4.44L.0207292136040.3086-100000@imladris.surriel.com
Rik van Riel wrote:
>
> ...
> + read_lock(&mapping->page_lock);
> + for (page_idx = offset; page_idx > lower_limit; page_idx--) {
> + page = radix_tree_lookup(&mapping->page_tree, page_idx);
> +
> + if (!page || (!PageActive(page) && !PageReferenced(page)))
> + break;
> +
> + deactivate_page(page);
> + }
> + read_unlock(&mapping->page_lock);
A lock ranking bug here, I think.
But that is OK - I'm bringing the pagevec code uptodate.
When that's up and running I can slot all the pages
into a pagevec here and do a gang deactivate outside the
page_lock.
I wonder how to test this?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
prev parent reply other threads:[~2002-07-30 0:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-30 0:39 [PATCH] nru replacement for 2.5.29 Rik van Riel
2002-07-30 0:55 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D45E400.8E6DC52C@zip.com.au \
--to=akpm@zip.com.au \
--cc=linux-mm@kvack.org \
--cc=riel@conectiva.com.br \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.