From: Brian Gerst <bgerst@didntduck.org>
To: Jonathan Buzzard <jonathan@buzzard.org.uk>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
John Weber <john.weber@linux.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Toshiba Laptop Support and IRQ Locks
Date: Fri, 02 Aug 2002 15:49:06 -0400 [thread overview]
Message-ID: <3D4AE232.6010000@didntduck.org> (raw)
In-Reply-To: E17aiHh-00034N-00@jelly.buzzard.org.uk
Jonathan Buzzard wrote:
> alan@lxorguk.ukuu.org.uk said:
>
>>Hi,
>>
>>Toshiba laptop support is broken. Here's my rookie attempt at fixing
>>it.
>
>
> Whats broken? I have not seen the patch, though I don't track the latest
> 2.5 kernels either.
>
>
>>Looks basically sound. You probably want to use spinlock_irqsave - the
>>spin locks are less overhead than the reader/writer locks and you
>>don't really seem to be using it for anything else. I'm assuming we
>>want the irqsave to block interrupts because the I/O cycles might have
>>to happen one after another - if not they could be relaxed - perhaps
>>Jonathan knows ?
>
>
> Someone show me the patch and I can say for sure.
>
> Two things to bare in mind, Toshiba have yet to do any sort of
> multi processor laptop, are extremely unlikely to ever manufacture
> one, and to the best of my knowledge the module only loads on Toshiba
> laptops. If it loads on anything else it is broken and needs fixing
> so it does not.
What about P4 Hyperthreading?
--
Brian Gerst
next prev parent reply other threads:[~2002-08-02 19:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-02 16:03 [PATCH] Toshiba Laptop Support and IRQ Locks John Weber
2002-08-02 17:55 ` Alan Cox
2002-08-02 19:40 ` Jonathan Buzzard
2002-08-02 19:49 ` Brian Gerst [this message]
2002-08-04 4:27 ` Jonathan Buzzard
2002-08-02 23:05 ` John Weber
-- strict thread matches above, loose matches on Subject: below --
2002-09-10 22:25 rwhron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D4AE232.6010000@didntduck.org \
--to=bgerst@didntduck.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=john.weber@linux.org \
--cc=jonathan@buzzard.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.