From: Stas Sergeev <stssppnn@yahoo.com>
To: linux-msdos@vger.kernel.org
Subject: Re: [PATCH][1.1.3.2] keystroke - option P not working (unicode keyboard)
Date: Sun, 04 Aug 2002 15:59:50 +0400 [thread overview]
Message-ID: <3D4D1736.6020501@yahoo.com> (raw)
Hello.
Per Jessen wrote:
> let me know - it works here.
Good :)
> If you don't like the added
> debug output, well ... :-)
I don't like it because you
have a single string duplicating
many times. Just putting it
right before the switch() would
be OKey I think. Also for 'A'
you are adding that string after
"ch=*(in++);" and for M - before,
which seems buggy.
Decorating the bugfix with
a debug changes is not a problem
in general but it should be more
accurate.
But anyway this doesn't as matter
as the change you propose for
unicode_utils.c, which, unless
you can justify it of course,
is not recommended to apply at
all.
next reply other threads:[~2002-08-04 11:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-04 11:59 Stas Sergeev [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-08-04 1:37 [PATCH][1.1.3.2] keystroke - option P not working (unicode keyboard) Stas Sergeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D4D1736.6020501@yahoo.com \
--to=stssppnn@yahoo.com \
--cc=linux-msdos@vger.kernel.org \
--cc=stas.orel@mailcity.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.