From: Carsten Langgaard <carstenl@mips.com>
To: Ralf Baechle <ralf@oss.sgi.com>
Cc: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>, linux-mips@oss.sgi.com
Subject: Re: [patch] 2.4: Revert interface removal
Date: Tue, 06 Aug 2002 08:46:56 +0200 [thread overview]
Message-ID: <3D4F70E0.5DCC7AD4@mips.com> (raw)
In-Reply-To: 20020805164729.A11853@dea.linux-mips.net
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
Ralf Baechle wrote:
> On Mon, Aug 05, 2002 at 03:04:13PM +0200, Carsten Langgaard wrote:
>
> > Ok, I finally figured out what the problem is.
> > The attached patch fix the problems, please apply.
>
> Applied, along with the 64-bit and 2.5 bits your patch was missing.
>
I was waiting for you to fix the bus_to_baddr in the 64-bit, I can see
you have have done something about it now, but I'm afraid you didn't get
it quite right.
Here is a patch to fix the typos.
/Carsten
--
_ _ ____ ___ Carsten Langgaard Mailto:carstenl@mips.com
|\ /|||___)(___ MIPS Denmark Direct: +45 4486 5527
| \/ ||| ____) Lautrupvang 4B Switch: +45 4486 5555
TECHNOLOGIES 2750 Ballerup Fax...: +45 4486 5556
Denmark http://www.mips.com
[-- Attachment #2: pci.h.patch --]
[-- Type: text/plain, Size: 900 bytes --]
Index: include/asm-mips64/pci.h
===================================================================
RCS file: /cvs/linux/include/asm-mips64/pci.h,v
retrieving revision 1.16.2.9
diff -u -r1.16.2.9 pci.h
--- include/asm-mips64/pci.h 2002/08/06 02:21:50 1.16.2.9
+++ include/asm-mips64/pci.h 2002/08/06 06:36:35
@@ -213,8 +213,8 @@
out_of_line_bug();
dma_cache_wback_inv((unsigned long)sg->address, sg->length);
- sg->address = bus_to_baddr(hwdev->bus->number) |
- virt_to_bus(sg->address);
+ sg->address = bus_to_baddr(hwdev->bus->number,
+ virt_to_bus(sg->address));
}
return nents;
@@ -251,7 +251,7 @@
if (direction == PCI_DMA_NONE)
out_of_line_bug();
- dma_cache_wback_inv((unsigned long)__va(dma_handle - bus_to_baddr(hwdev->bus->number)), size);
+ dma_cache_wback_inv((unsigned long)__va(bus_to_baddr(hwdev->bus->number, dma_handle)), size);
}
/*
next prev parent reply other threads:[~2002-08-06 6:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-05 9:05 [patch] 2.4: Revert interface removal Maciej W. Rozycki
2002-08-05 10:41 ` Ralf Baechle
2002-08-05 11:05 ` Carsten Langgaard
2002-08-05 11:53 ` Carsten Langgaard
2002-08-05 13:04 ` Carsten Langgaard
2002-08-05 14:47 ` Ralf Baechle
2002-08-06 6:46 ` Carsten Langgaard [this message]
2002-08-06 9:05 ` Carsten Langgaard
2002-08-05 11:20 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D4F70E0.5DCC7AD4@mips.com \
--to=carstenl@mips.com \
--cc=linux-mips@oss.sgi.com \
--cc=macro@ds2.pg.gda.pl \
--cc=ralf@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.