diff for duplicates of <3D511AD9.F041F7BE@attbi.com> diff --git a/a/1.txt b/N1/1.txt index 87798e3..d8bf5b6 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -42,7 +42,7 @@ Russell King wrote: > > > + if (priv_data->iic_irq > 0) { > > + spin_lock_irq(&driver_lock); -> > + if (iic_pending = 0) { +> > + if (iic_pending == 0) { > > + interruptible_sleep_on_timeout(&(iic_wait[priv_data->index]), timeout*HZ ); > > You shouldn't be scheduling with interrupts disabled, spinlock locked. @@ -61,11 +61,12 @@ Russell King wrote: > that IRQ. Secondly, free_irq will disable the interrupt source for you, so > its redundant anyway. > -> > + if (cpm->reloc = 0) { +> > + if (cpm->reloc == 0) { > > + volatile cpm8xx_t *cp = cpm->cp; > > + > > + if (cpm_debug) printk("force_close()\n"); -> > + cp->cp_cpcr > > + mk_cr_cmd(CPM_CR_CH_I2C, CPM_CR_CLOSE_RXBD) | +> > + cp->cp_cpcr = +> > + mk_cr_cmd(CPM_CR_CH_I2C, CPM_CR_CLOSE_RXBD) | > > + CPM_CR_FLG; > > + > > + while (cp->cp_cpcr & CPM_CR_FLG); @@ -104,7 +105,7 @@ Russell King wrote: > > + > > + if (gpe.pe_irq > 0) { > > + spin_lock_irq(&driver_lock); -> > + if (pcf_pending = 0) { +> > + if (pcf_pending == 0) { > > + interruptible_sleep_on_timeout(&pcf_wait, timeout*HZ); > > + //udelay(100); > > + } else { diff --git a/a/content_digest b/N1/content_digest index e08d21b..34ff6fa 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\03D50B01F.53D7FFF5@attbi.com\0" "ref\020020807102346.A5934@flint.arm.linux.org.uk\0" - "From\0ac9410@attbi.com (Albert Cranford)\0" - "Subject\0[PATCH]2.5.30 i2c updates 3/4\0" - "Date\0Thu, 19 May 2005 06:23:37 +0000\0" + "From\0Albert Cranford <ac9410@attbi.com>\0" + "Subject\0Re: [PATCH]2.5.30 i2c updates 3/4\0" + "Date\0Wed, 07 Aug 2002 09:04:25 -0400\0" "To\0Russell King <rmk@arm.linux.org.uk>" Linus Torvalds <torvalds@transmeta.com> " LM Sensors <sensors@stimpy.netroedge.com>\0" @@ -53,7 +53,7 @@ "> \n" "> > + if (priv_data->iic_irq > 0) {\n" "> > + spin_lock_irq(&driver_lock);\n" - "> > + if (iic_pending = 0) {\n" + "> > + if (iic_pending == 0) {\n" "> > + interruptible_sleep_on_timeout(&(iic_wait[priv_data->index]), timeout*HZ );\n" "> \n" "> You shouldn't be scheduling with interrupts disabled, spinlock locked.\n" @@ -72,11 +72,12 @@ "> that IRQ. Secondly, free_irq will disable the interrupt source for you, so\n" "> its redundant anyway.\n" "> \n" - "> > + if (cpm->reloc = 0) {\n" + "> > + if (cpm->reloc == 0) {\n" "> > + volatile cpm8xx_t *cp = cpm->cp;\n" "> > +\n" "> > + if (cpm_debug) printk(\"force_close()\\n\");\n" - "> > + cp->cp_cpcr > > + mk_cr_cmd(CPM_CR_CH_I2C, CPM_CR_CLOSE_RXBD) |\n" + "> > + cp->cp_cpcr =\n" + "> > + mk_cr_cmd(CPM_CR_CH_I2C, CPM_CR_CLOSE_RXBD) |\n" "> > + CPM_CR_FLG;\n" "> > +\n" "> > + while (cp->cp_cpcr & CPM_CR_FLG);\n" @@ -115,7 +116,7 @@ "> > +\n" "> > + if (gpe.pe_irq > 0) {\n" "> > + spin_lock_irq(&driver_lock);\n" - "> > + if (pcf_pending = 0) {\n" + "> > + if (pcf_pending == 0) {\n" "> > + interruptible_sleep_on_timeout(&pcf_wait, timeout*HZ);\n" "> > + //udelay(100);\n" "> > + } else {\n" @@ -175,4 +176,4 @@ "Albert Cranford Deerfield Beach FL USA\n" ac9410@bellsouth.net -873181d5a6d8c74b95be3ff5ea2d6913dff535815ce7176b6cb649109f6f063c +3b3bf5b8160079d9240761a84faaeafc6fd7d074e3145330912b021b9a5905aa
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.