All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@zip.com.au>
To: j-nomura@ce.jp.nec.com
Cc: hugh@veritas.com, linux-kernel@vger.kernel.org
Subject: Re: 2.4.18(19) swapcache oops
Date: Thu, 15 Aug 2002 21:40:26 -0700	[thread overview]
Message-ID: <3D5C823A.4850F8B5@zip.com.au> (raw)
In-Reply-To: 20020816.131922.730554388.nomura@hpc.bs1.fc.nec.co.jp

j-nomura@ce.jp.nec.com wrote:
> 
> Thank you for the solutions.
> Your first patch seems to fix the problem in 2.4.

You must have been able to reproduce it quite quickly.  But the
code has been like that for ages.  Why is that?  Are you testing
on an unusual machine?

> As to the second fix from 2.5.32, it can't be applicable to 2.4, can it?
> try_to_swap_out() may call add_to_swap_cache() with PG_lru page.

Ah, good point.  In 2.5, add_to_page_cache() does not add the
page to the LRU.  Anonymous pages are already there, and we
don't need to do that.  The first patch should be OK.

  reply	other threads:[~2002-08-16  4:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-15 12:39 2.4.18(19) swapcache oops j-nomura
2002-08-15 14:32 ` Hugh Dickins
2002-08-15 20:05   ` Andrew Morton
2002-08-15 20:21     ` Andrew Morton
2002-08-16  4:19       ` j-nomura
2002-08-16  4:40         ` Andrew Morton [this message]
2002-08-16  8:07           ` j-nomura
2002-08-15 22:59     ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D5C823A.4850F8B5@zip.com.au \
    --to=akpm@zip.com.au \
    --cc=hugh@veritas.com \
    --cc=j-nomura@ce.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.