From: "David D. Hagood" <wowbagger@sktc.net>
To: Adam Belay <ambx1@netscape.net>
Cc: Patrick Mochel <mochel@osdl.org>, Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.31 driverfs: patch for your consideration
Date: Sat, 17 Aug 2002 08:52:03 -0500 [thread overview]
Message-ID: <3D5E5503.9000705@sktc.net> (raw)
In-Reply-To: 3D5D7E50.4030307@netscape.net
Adam Belay wrote:
> +static ssize_t device_read_driver(struct device * dev, char * buf,
> size_t count, loff_t off)
> +{
> + if (dev->driver)
> + return off ? 0 : sprintf(buf,"%s\n",dev->driver->name);
You aren't checking that the name will fit in the supplied buffer - what
is there isn't enough space? Shouldn't you either use snprintf, a
strncpy, or a maximum field width in the sprintf?
next prev parent reply other threads:[~2002-08-17 13:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-16 22:36 [PATCH] 2.5.31 driverfs: patch for your consideration Adam Belay
2002-08-17 3:06 ` Greg KH
2002-08-17 14:10 ` Adam Belay
2002-08-17 19:03 ` Greg KH
2002-08-17 22:32 ` Adam Belay
2002-08-18 21:46 ` Greg KH
2002-08-18 21:47 ` Greg KH
2002-08-23 17:45 ` [PATCH] 2.5.31 port PnP BIOS to the driver model Adam Belay
2002-08-27 21:40 ` [PATCH] 2.5.32 port PnP BIOS to the driver model RESEND #1 Adam Belay
2002-08-28 5:14 ` Greg KH
2002-08-29 20:36 ` Adam Belay
2002-08-30 5:28 ` Greg KH
2002-08-30 14:47 ` Adam Belay
2002-08-30 14:48 ` [PATCH] 2.5.32 port PnP BIOS to the driver model - ready for inclusion Adam Belay
2002-08-19 18:10 ` [PATCH] 2.5.31 driverfs: patch for your consideration Patrick Mochel
2002-08-19 15:35 ` Adam Belay
2002-08-17 13:52 ` David D. Hagood [this message]
2002-08-17 19:43 ` Alan Cox
2002-08-19 18:19 ` Patrick Mochel
2002-08-19 15:50 ` Adam Belay
2002-08-19 19:59 ` Greg KH
2002-08-19 21:54 ` Adam Belay
2002-08-20 3:32 ` Greg KH
2002-08-20 6:51 ` jw schultz
2002-08-20 18:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D5E5503.9000705@sktc.net \
--to=wowbagger@sktc.net \
--cc=ambx1@netscape.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.