From: Luben Tuikov <luben@splentec.com>
To: linux-scsi <linux-scsi@vger.kernel.org>
Subject: [CARE]: number of LUNS from REPORT LUNS data report and macros
Date: Mon, 26 Aug 2002 20:49:38 -0400 [thread overview]
Message-ID: <3D6ACCA2.68364DDA@splentec.com> (raw)
Two issues here.
Firstly, I don't think that one can quite do
``num_luns = (length / sizeof(ScsiLun));'' in scsi_scan.c.
The reason is that we should keep clear separation of what/how
the kernel represents some standard/drafts data and how it comes
from the device. I.e. one wouldn't assume (one step further) that
_also_ the byte ordering is the same in the report data and in ScsiLun,
i.e. (ScsiLun *)(data+i*sizeof(ScsiLun)) ... not!
A SCSI LUN should be represented by ``u64''. Futhermore, only
a LLDD should poplulate such a variable (as outlined in another email)
directly or indirectly (though REPORT LUNS data).
Secondly, please get rid of the big
#ifdef CONFIG_SCSI_REPORT_LUNS in scsi_scan.c.
Linus has made this a point numerous times.
Lets keep this great subsystem great!
(Those issues should naturally go away once u64 LUN is adopted.)
--
Luben
next reply other threads:[~2002-08-27 0:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-27 0:49 Luben Tuikov [this message]
2002-08-27 1:10 ` [CARE]: number of LUNS from REPORT LUNS data report and macros Patrick Mansfield
2002-08-29 18:54 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D6ACCA2.68364DDA@splentec.com \
--to=luben@splentec.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.