All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Malek <dan@embeddededge.com>
To: acurtis@onz.com
Cc: linuxppc-embedded@lists.linuxppc.org
Subject: Re: FCC patch..really
Date: Tue, 27 Aug 2002 23:52:36 -0400	[thread overview]
Message-ID: <3D6C4904.1060101@embeddededge.com> (raw)
In-Reply-To: 200208271708.04797.acurtis@onz.com


Allen Curtis wrote:


> +    if [ "$CONFIG_FCC1_ENET" = "y" ]; then
> +      choice 'RX Clk Source'	\

Please don't do this.......it doesn't belong in the configuration
file.  There are more things unique to a board configuration than
the clock routing.  This belongs as a structure in a C file, selectable
by board type (along with other board specific selections).

Thanks.


	-- Dan


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

  reply	other threads:[~2002-08-28  3:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-28  0:08 FCC patch..really Allen Curtis
2002-08-28  3:52 ` Dan Malek [this message]
2002-08-28  4:11   ` Allen Curtis
2002-08-28  5:29     ` Dan Malek
2002-08-28 14:43       ` Allen Curtis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D6C4904.1060101@embeddededge.com \
    --to=dan@embeddededge.com \
    --cc=acurtis@onz.com \
    --cc=linuxppc-embedded@lists.linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.