Re: [PATCH] slabasap-mm5_A2

[Andrew Morton <akpm@digeo.com>]

Andrew Morton wrote:
> 
> ...
> If we have the pruner callbacks then vmscan can just do:
> 
>         kmem_shrink_stuff(ratio);
> 
> and then kmem_shrink_stuff() can do:
> 
>         cachep->nr_to_prune += cacheb->inuse / ratio;
>         if (cachep->nr_to_prune > cachep->prune_batch) {
>                 int prune = cachep->nr_to_prune;
> 
>                 cachep->nr_to_prune = 0;
>                 (*cachep->pruner)(nr_to_prune);
>         }

OK, I get it.  `ratio' here can easily be 100,000, which would
result in zero objects to prune all the time.  So it's

	cachep->nr_to_prune += cacheb->inuse / ratio + 1;

yes?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/