From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Albert Cranford <ac9410@attbi.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [patch 9/9]Four new i2c drivers and __init/__exit cleanup to i2c
Date: Sun, 15 Sep 2002 19:18:46 -0400 [thread overview]
Message-ID: <3D851556.7070203@mandrakesoft.com> (raw)
In-Reply-To: Pine.LNX.4.44.0209151845330.7637-200000@home1
Albert Cranford wrote:
> --- linux/drivers/i2c/i2c-elektor.c.orig 2002-09-14 22:10:45.000000000 -0400
> +++ linux-2.5.34/drivers/i2c/i2c-elektor.c 2002-09-15 01:18:55.000000000 -0400
> @@ -125,12 +125,12 @@
> int timeout = 2;
>
> if (irq > 0) {
> - cli();
> + local_irq_disable();
> if (pcf_pending == 0) {
> interruptible_sleep_on_timeout(&pcf_wait, timeout*HZ );
> } else
> pcf_pending = 0;
> - sti();
> + local_irq_enable();
> } else {
> udelay(100);
> }
this is _not_ the way to fix... use a proper spinlock
next prev parent reply other threads:[~2002-09-15 23:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-15 22:46 [patch 9/9]Four new i2c drivers and __init/__exit cleanup to i2c Albert Cranford
2002-09-15 23:18 ` Jeff Garzik [this message]
2002-09-15 23:26 ` Russell King
2002-09-15 23:31 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D851556.7070203@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=ac9410@attbi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.