From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Andrew Morton <akpm@digeo.com>
Cc: "Cureington, Tony" <tony.cureington@hp.com>,
Pascal Brisset <pascal.brisset-ml@wanadoo.fr>,
bonding-devel@lists.sourceforge.net, netdev@oss.sgi.com
Subject: Re: [Bonding-devel] Re: Bonding driver unreliable under high CPUload
Date: Tue, 17 Sep 2002 16:11:02 -0400 [thread overview]
Message-ID: <3D878C56.2070400@mandrakesoft.com> (raw)
In-Reply-To: 3D878841.EB580DE9@digeo.com
Andrew Morton wrote:
> Jeff Garzik wrote:
>
>>...
>>Also, a further question: do you have access to the slave struct
>>net_device? If so, just test netif_carrier_ok(slave_dev) and avoid all
>>that ioctl calling if it returns non-zero.
>
>
> Make that "avoid all that ioctl calling from interrupt context", which
> is a bug. Of the box-killing variety ;)
Indeed. /me looks at the bond_check_dev_link callers more closely and
shudders.
That wants fixing...
Note that netif_carrier_ok() can indeed be checked in interrupt context.
And if someone wants to send me patches converting more drivers to use
netif_carrier_{on,off}, I would be very happy :)
next prev parent reply other threads:[~2002-09-17 20:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-17 19:28 [Bonding-devel] Re: Bonding driver unreliable under high CPU load Cureington, Tony
2002-09-17 19:45 ` Jeff Garzik
2002-09-17 19:53 ` [Bonding-devel] Re: Bonding driver unreliable under high CPUload Andrew Morton
2002-09-17 19:58 ` Chad N. Tindel
2002-09-17 20:07 ` Jeff Garzik
2002-09-17 20:11 ` Chad N. Tindel
2002-09-17 20:23 ` Jeff Garzik
2002-09-17 20:11 ` Jeff Garzik [this message]
2002-09-17 20:24 ` Andrew Morton
2002-09-17 20:30 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2002-09-17 20:37 Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D878C56.2070400@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=akpm@digeo.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=netdev@oss.sgi.com \
--cc=pascal.brisset-ml@wanadoo.fr \
--cc=tony.cureington@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.