From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: "Cureington, Tony" <tony.cureington@hp.com>,
Andrew Morton <akpm@digeo.com>,
Pascal Brisset <pascal.brisset-ml@wanadoo.fr>,
bonding-devel@lists.sourceforge.net, netdev@oss.sgi.com
Subject: Re: [Bonding-devel] Re: Bonding driver unreliable under high CPU load
Date: Tue, 17 Sep 2002 16:15:53 -0400 [thread overview]
Message-ID: <3D878D79.20904@mandrakesoft.com> (raw)
In-Reply-To: OF5FEED16C.9C2ED639-ON88256C37.006CA80A@boulder.ibm.com
Jay Vosburgh wrote:
>
> Well, now that it's been pointed out to me, that does look pretty
> grotty. It works because MII_LINK_READY is defined to be 4, and the return
> from bond_check_dev_link() is always a bitwise test against MII_LINK_READY,
> so it works. Could be cleaner, though.
Yep. Sounds like you also might want to replace a non-standard constant
(MII_LINK_READY) with its standard constant from linux/mii.h,
BMSR_LSTATUS, too, if you are going to use it like this.
> As far as netif_carrier_ok() goes, is it reliable? In looking at the
> drivers, it appears that some don't update the flag (e.g., 3c59x.c).
No. Only some drivers implement it at present -- though all should.
Patches to fix up drivers to use netif_carrier_{on,off} would be very
welcome. There are several examples in-tree to emulate...
Jeff
next prev parent reply other threads:[~2002-09-17 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-17 20:01 [Bonding-devel] Re: Bonding driver unreliable under high CPU load Jay Vosburgh
2002-09-17 20:15 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-09-17 19:46 Jay Vosburgh
2002-09-17 19:28 Cureington, Tony
2002-09-17 19:45 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D878D79.20904@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=akpm@digeo.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=fubar@us.ibm.com \
--cc=netdev@oss.sgi.com \
--cc=pascal.brisset-ml@wanadoo.fr \
--cc=tony.cureington@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.