All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 4/4] increase traffic on linux-kernel
Date: Wed, 25 Sep 2002 21:31:27 -0700	[thread overview]
Message-ID: <3D928D9F.7BF85410@digeo.com> (raw)
In-Reply-To: 3D928C8B.5020609@pobox.com

Jeff Garzik wrote:
> 
> Andrew Morton wrote:
> > --- 2.5.38/include/linux/kernel.h~might_sleep Wed Sep 25 20:15:27 2002
> > +++ 2.5.38-akpm/include/linux/kernel.h        Wed Sep 25 20:15:27 2002
> > @@ -40,6 +40,13 @@
> >
> >  struct completion;
> >
> > +#ifdef CONFIG_DEBUG_KERNEL
> > +void __might_sleep(char *file, int line);
> > +#define might_sleep() __might_sleep(__FILE__, __LINE__)
> > +#else
> > +#define might_sleep() do {} while(0)
> > +#endif
> 
> I disagree with this -- CONFIG_DEBUG_KERNEL should not enable any machinery.

I did this because adding a function call to down() and friends
has significant cost.

> Magic Sysrq should be enable-able without affecting any other parts of
> the kernel.

A separate config option then?

  reply	other threads:[~2002-09-26  4:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-26  4:09 [patch 4/4] increase traffic on linux-kernel Andrew Morton
2002-09-26  4:26 ` Jeff Garzik
2002-09-26  4:31   ` Andrew Morton [this message]
2002-09-26  4:35     ` Jeff Garzik
2002-09-26  4:32   ` Andrew Morton
2002-09-26  4:32 ` Greg KH
2002-09-26  4:37   ` Andrew Morton
2002-09-27  1:31 ` Linus Torvalds
2002-09-27  1:34   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D928D9F.7BF85410@digeo.com \
    --to=akpm@digeo.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.