From: Jeff Garzik <jgarzik@pobox.com>
To: Kent Yoder <key@austin.ibm.com>
Cc: linux-kernel@vger.kernel.org, tsbogend@alpha.franken.de
Subject: Re: [PATCH] pcnet32 cable status check
Date: Mon, 30 Sep 2002 16:21:50 -0400 [thread overview]
Message-ID: <3D98B25E.2010408@pobox.com> (raw)
In-Reply-To: Pine.LNX.4.44.0209301421100.13906-100000@ennui.austin.ibm.com
Comments:
It looks good as a starting point :)
I just added mii_check_media() to drivers/net/mii.c. It's in the latest
2.5.x snapshot,
ftp://ftp.kernel.org/pub/linux/kernel/v2.5/snapshots/patch-2.5.39-bk2.bz2
and is in Marcelo's inbox as well. For simple implementations (and I
think pcnet32 qualifies), the timer should not need to do anything
beyond calling mii_check_media(). One important feature of this is use
of the standard netif_carrier_{off,on} to indicate link to the system.
netif_carrier_xxx also means you don't need lp->link...
next prev parent reply other threads:[~2002-09-30 20:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-30 19:31 [PATCH] pcnet32 cable status check Kent Yoder
2002-09-30 20:21 ` Jeff Garzik [this message]
2002-09-30 21:48 ` Oops on 2.5.39 was " Kent Yoder
2002-09-30 21:55 ` Jeff Garzik
2002-10-01 16:34 ` Kent Yoder
2002-10-01 16:50 ` Felipe W Damasio
2002-10-01 17:07 ` Jeff Garzik
2002-10-01 17:19 ` Kent Yoder
2002-10-01 17:19 ` Jeff Garzik
2002-10-01 17:30 ` Kent Yoder
2002-10-01 17:36 ` Jeff Garzik
2002-10-01 19:35 ` Kent Yoder
2002-10-01 17:40 ` Felipe W Damasio
2002-10-07 15:31 ` Kent Yoder
2002-10-22 1:33 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D98B25E.2010408@pobox.com \
--to=jgarzik@pobox.com \
--cc=key@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.