From: Andrew Morton <akpm@digeo.com>
To: Alexander Viro <viro@math.psu.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [LART] inode mismanagement in hugetlb code
Date: Thu, 10 Oct 2002 12:22:28 -0700 [thread overview]
Message-ID: <3DA5D374.330E5970@digeo.com> (raw)
In-Reply-To: Pine.GSO.4.21.0210101447390.13421-100000@weyl.math.psu.edu
Alexander Viro wrote:
>
> [A discussion of the meanings of the terms "MUST", "SHOULD", and "MAY" appears
> in RFC-1123; the terms "MUST NOT" and "SHOULD NOT" are logical extensions of
> this usage]
>
> a) inodes MUST have an address of valid struct super_block in their
> ->i_sb. Had been discussed quite a few times already.
>
afaict, that code only wants an inode because it is borrowing
the pagecache functions for page lookup. It's using i_ino as
a search key too. It has no superblock.
Solutions might be: 1) allocate a private <int key, radix tree>
structure or 2) require that these inodes come from hugetlbfs,
although the "key" makes that a bit tricky.
next prev parent reply other threads:[~2002-10-10 19:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-10 19:00 [LART] inode mismanagement in hugetlb code Alexander Viro
2002-10-10 19:19 ` William Lee Irwin III
2002-10-10 19:22 ` Andrew Morton [this message]
2002-10-10 19:43 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DA5D374.330E5970@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.