From: Stefan Rompf <srompf@isg.de>
To: Tim Hockin <thockin@sun.com>
Cc: netdev@oss.sgi.com, linux-net@vger.kernel.org
Subject: Re: PATCH idea - netlink and link changes
Date: Sat, 12 Oct 2002 11:23:39 +0200 [thread overview]
Message-ID: <3DA7EA1B.3D0430F@isg.de> (raw)
In-Reply-To: 3DA7035F.5080101@sun.com
Hi Tim,
> Looking for feedback on this quickie patch. This enables netlink to
> deliver link-change events, as reported by drivers via
> netif_carrier_{on,off}.
I've taken a closer look at the approach and like it more than my own
implementation. What you are currently missing is some code to assure
that a device does not have an event queued after removal - look what my
patch does in netdev_unregister(). Patching f.e. the vlan driver to do
some netif_carrier_on/off in the stop method is a good test case. Also,
do not forget to call the network notifier chain beside emitting a
netlink message - the kernel isinterested in the event, too.
IMHO we should merge the patches, taking your one workqueue per device
approach and my usage of IFF_RUNNING as a mirror bit. What do other
netdev people think?
Cheers, Stefan
next prev parent reply other threads:[~2002-10-12 9:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-11 16:59 PATCH idea - netlink and link changes Tim Hockin
2002-10-12 0:12 ` Stefan Rompf
2002-10-12 9:23 ` Stefan Rompf [this message]
2002-10-12 9:11 ` David S. Miller
2002-10-12 13:10 ` jamal
2002-10-14 18:07 ` Tim Hockin
2002-10-14 18:17 ` Stefan Rompf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DA7EA1B.3D0430F@isg.de \
--to=srompf@isg.de \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=thockin@sun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.