Re: [PATCH] PnP Layer Rewrite V0.7 - 2.4.42

[Jeff Garzik <jgarzik@pobox.com>]

Jaroslav Kysela wrote:
> On Mon, 14 Oct 2002, Adam Belay wrote:
> 
> 
>>Linux Plug and Play Rewrite V0.7
>>
>>After much testing the Linux PnP Rewrite is ready to be included. For
>>those who would like to try it, be sure to enable debugging or else it
>>will operate silently. Also enable both PnP protocols.
> 
> 
> A few notes. Please, could you leave the raw proc interface for ISA PnP?

If a rewrite is being done, there are a lot better ways to do this than 
via ->proc_read and ->proc_write...  plus overall procfs usage should be 
deprecated where reasonable/possible...


> I mean isapnp_proc_bus_read() function. Also, encoding device/vendor to 
> 7-byte string seems like wasting bytes and CPU cycles. If you use 2/2 byte 
> format, you'll spare 3 bytes and comparing of two short values (or one 
> int value) is always less expensive.

ASCII has always been preferred.  google for "Linus", "linux-kernel", 
and "ASCII" to see Linus's several postings on the subject...


> Anyway, I like this code. It seems that you don't use standard pci_dev / 
> pci_bus structures as I was forced by Linus at ISA PnP code inclusion 
> time. But it's true that we have new device model, so these things might 
> be private. Also, don't forget to remove additional ISA PnP members from 
> pci structures when Linus approves pnp_dev and pnp_card structures.

agreed.

Regards,

	Jeff