All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Matthew Wilcox <willy@debian.org>
Cc: Linus Torvalds <torvalds@transmeta.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] default VM flags for upwards-growing stacks
Date: Wed, 16 Oct 2002 14:56:22 -0400	[thread overview]
Message-ID: <3DADB656.7080105@pobox.com> (raw)
In-Reply-To: 20021016194238.O15163@parcelfarce.linux.theplanet.co.uk

Matthew Wilcox wrote:
> diff -urpNX build-tools/dontdiff linus-2.5/include/linux/mm.h parisc-2.5/include/linux/mm.h
> --- linus-2.5/include/linux/mm.h	Tue Oct  8 10:54:13 2002
> +++ parisc-2.5/include/linux/mm.h	Tue Oct  8 16:49:15 2002
> @@ -106,7 +106,11 @@ struct vm_area_struct {
>  #define VM_ACCOUNT	0x00100000	/* Is a VM accounted object */
>  #define VM_HUGETLB	0x00400000	/* Huge TLB Page VM */
>  
> -#define VM_STACK_FLAGS	(0x00000100 | VM_DATA_DEFAULT_FLAGS | VM_ACCOUNT)
> +#ifdef ARCH_STACK_GROWSUP
> +#define VM_STACK_FLAGS	(VM_GROWSUP | VM_DATA_DEFAULT_FLAGS | VM_ACCOUNT)
> +#else
> +#define VM_STACK_FLAGS	(VM_GROWSDOWN | VM_DATA_DEFAULT_FLAGS | VM_ACCOUNT)
> +#endif


is it worth it to crease a VM_GROW_DIR define instead?

then there is no ifdef in linux/mm.h, just an arch-dependent define.


      reply	other threads:[~2002-10-16 18:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-16 18:42 [PATCH] default VM flags for upwards-growing stacks Matthew Wilcox
2002-10-16 18:56 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DADB656.7080105@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    --cc=willy@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.