Re: [PATCH 2/2] High-res-timers part 2 (x86 platform code) take 6

[george anzinger <george@mvista.com>]

Pavel Machek wrote:
> 
> Hi!
> 
> > This patch, in conjunction with the "core" high-res-timers
> > patch implements high resolution timers on the i386
> > platforms.  The high-res-timers use the periodic interrupt
> > to "remind" the system to look at the clock.  The clock
> 
> This scares me:
> 
> +#define fail_message \
> +"High-res-timers:
> >-<--><-->-<-->-<-->-<--><-->-<-->-<-->-<-->-<-->-<-->-<-->-<\n"\
> +"High-res-timers: >Failed to find the ACPI pm timer
> <\n"\
> +"High-res-timers: >-<--><-->-<-->-<-->-<-->Boot will fail in
> Calibrate Delay  <\n"\
> +"High-res-timers: >Supply a valid default pm timer address
> <\n"\
> +"High-res-timers: >or get your BIOS to turn on ACPI support.
> <\n"\
> +"High-res-timers: >See CONFIGURE help for more information.
> <\n"\
> +"High-res-timers:
> >-<--><-->-<-->-<-->-<--><-->-<-->-<-->-<-->-<-->-<-->-<-->-<\n"
> 
> Does that mean our boot has now so much junk in it that we start
> adding ascii art for "important" messages?

Well, Yes! It does.  However, the problem here is that this
is detected prior to enabling the console so, unless the
boot can limp along until that happens, this message will
not be seen.  I have seen both conditions...

I am open to suggestions...

Thanks for looking.


-- 
George Anzinger   george@mvista.com
High-res-timers: 
http://sourceforge.net/projects/high-res-timers/
Preemption patch:
http://www.kernel.org/pub/linux/kernel/people/rml