From: Jeff Garzik <jgarzik@pobox.com>
To: "H. J. Lu" <hjl@lucon.org>
Cc: Greg KH <greg@kroah.com>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: Support PCI device sorting (Re: PCI device order problem)
Date: Sun, 27 Oct 2002 19:26:40 -0500 [thread overview]
Message-ID: <3DBC8440.4030603@pobox.com> (raw)
In-Reply-To: 20021027124248.A8019@lucon.org
H. J. Lu wrote:
>On Sun, Oct 27, 2002 at 09:42:49AM -0800, Greg KH wrote:
>
>
>>On Sat, Oct 26, 2002 at 05:25:26PM -0700, H. J. Lu wrote:
>>
>>
>>>On Sat, Oct 26, 2002 at 08:05:13PM -0400, Jeff Garzik wrote:
>>>
>>>
>>>>Jeff Garzik wrote:
>>>>
>>>>
>>>>
>>>>>s/__devinit/__init/ and the implementation looks ok to me
>>>>>
>>>>>
>>>>
>>>>...except if your patch can be called in hotplug paths...
>>>>
>>>>
>>>There are plenty of __devini in arch/i386/kernel/pci-pc.c. I will leave
>>>mine alone.
>>>
>>>
>>That is because those functions can be called in PCI hotplug paths,
>>since yours is only called during init, it should be marked as such.
>>
>>
>>
>
>Are you telling me that pcibios_sort will be called by PCI hotplug?
>
>
no, he's saying __init is correct, as Alan and I said.
Jeff
next prev parent reply other threads:[~2002-10-28 0:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-24 23:39 PCI device order problem H. J. Lu
2002-10-24 23:49 ` Jeff Garzik
2002-10-24 23:56 ` H. J. Lu
2002-10-25 0:14 ` Jeff Garzik
2002-10-25 0:18 ` H. J. Lu
2002-10-25 10:00 ` Alan Cox
2002-10-25 16:11 ` H. J. Lu
2002-10-26 3:26 ` PATCH: Support PCI device sorting (Re: PCI device order problem) H. J. Lu
2002-10-26 21:12 ` Jeff Garzik
2002-10-26 21:27 ` H. J. Lu
2002-10-26 21:34 ` Jeff Garzik
2002-10-26 21:44 ` H. J. Lu
2002-10-26 22:04 ` Jeff Garzik
2002-10-26 22:20 ` H. J. Lu
2002-10-26 22:29 ` Jeff Garzik
2002-10-26 22:53 ` H. J. Lu
2002-10-26 22:58 ` Jeff Garzik
2002-10-26 23:45 ` Alan Cox
2002-10-26 23:53 ` H. J. Lu
2002-10-26 23:57 ` Jeff Garzik
2002-10-27 0:05 ` Jeff Garzik
2002-10-27 0:25 ` H. J. Lu
2002-10-27 17:42 ` Greg KH
2002-10-27 20:42 ` H. J. Lu
2002-10-28 0:26 ` Jeff Garzik [this message]
2002-10-27 0:30 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DBC8440.4030603@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=hjl@lucon.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.