All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Badari Pulavarty <badari@us.ibm.com>
Cc: linux-aio@kvack.org, lkml <linux-kernel@vger.kernel.org>,
	cel@citi.umich.edu
Subject: Re: [RFC] generic_file_direct_IO() argument changes for AIO
Date: Tue, 29 Oct 2002 10:58:08 -0800	[thread overview]
Message-ID: <3DBEDA40.449C8FFC@digeo.com> (raw)
In-Reply-To: 200210291819.g9TIJvO16528@eng2.beaverton.ibm.com

Badari Pulavarty wrote:
> 
> Hi,
> 
> Inorder to support AIO for raw/O_DIRECT, I need to add "struct kiocb *"
> to generic_file_direct_IO() and all direct_IO() ops.
> 
> generic_file_direct_IO(int rw, struct file *file, const struct iovec *iov,
>         loff_t offset, unsigned long nr_segs)
> 
> Instead of adding a new argument, I propose replace
> 
>         "struct file *file" argument with "struct kiocb *iocb"
> 
> One can get "filp" from iocb->ki_filp.
> 
> Any objections ?
> 

OK by me.

BTW, while you're poking around in there could you please rename
generic_direct_IO() to blockdev_direct_IO() and move
generic_file_direct_IO() back into filemap.c?

  reply	other threads:[~2002-10-29 18:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-29 18:19 [RFC] generic_file_direct_IO() argument changes for AIO Badari Pulavarty
2002-10-29 18:58 ` Andrew Morton [this message]
2002-10-29 19:15 ` Chuck Lever
2002-10-29 19:28   ` Badari Pulavarty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DBEDA40.449C8FFC@digeo.com \
    --to=akpm@digeo.com \
    --cc=badari@us.ibm.com \
    --cc=cel@citi.umich.edu \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.