From: Douglas Gilbert <dougg@torque.net>
To: wrlk@riede.org
Cc: Alexander Viro <viro@math.psu.edu>, linux-scsi@vger.kernel.org
Subject: Re: [patches] rq_dev removal
Date: Fri, 01 Nov 2002 13:43:04 +1100 [thread overview]
Message-ID: <3DC1EA38.2080105@torque.net> (raw)
In-Reply-To: 20021031231801.GE13860@linnie.riede.org
Willem Riede wrote:
> On 2002.10.31 17:43 Alexander Viro wrote:
>
>> Folks, ->rq_dev is going away in 2.5 RSN. The only non-trivial
>>remaining uses were in SCSI (scsi_lib.c::scsi_get_request_dev() and
>>uses in st.c, osst.c and sg.c to identify a device).
>>
>> Series of patches on ftp.math.psu.edu/pub/viro/P/P*-C45 deals
>>with that stuff and removes most of the uses of minor() in there. Please,
>>review it.
>
>
> I reviewed the changes to osst (which I maintain).
>
> [snip]
>
>> * sd.c and sr.c got a pointer to Scsi_Device_Template in
>>scsi_disk and scsi_cd resp. That pointer is initialized to &s{d,r}_template.
>>disk->private_data points to that field (instead of entire scsi_disk/scsi_cd)
>>and old uses of disk->private_data are updated to compensate.
>> * st.c, osst.c and sg.c got gendisks allocated, but not registered.
>
>
> How appropriate is it, to have something called '*disk' in a tape driver?
> I assume that at least the data in it is valid for this type of driver?
It seems as though sg's (scsi) _device_ abstraction has
been replaced by a _disk_ abstraction. At the very least
this is misleading for the dvd/cd writers, scanners,
tape robots and enclosures that sg typically deals with.
st, osst and sg are character device drivers (not block device
drivers).
<snip>
The patch on sg looks sound.
Doug Gilbert
next prev parent reply other threads:[~2002-11-01 2:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-31 22:43 [patches] rq_dev removal Alexander Viro
2002-10-31 22:57 ` James Bottomley
2002-10-31 23:18 ` Willem Riede
2002-10-31 23:40 ` Alexander Viro
2002-11-01 2:43 ` Douglas Gilbert [this message]
2002-11-01 14:05 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DC1EA38.2080105@torque.net \
--to=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
--cc=viro@math.psu.edu \
--cc=wrlk@riede.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.