From: Jeff Garzik <jgarzik@pobox.com>
To: Jochen Friedrich <jochen@scram.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, phillim2@comcast.net
Subject: Re: [PATCH] Update of tms380tr / tmsisa for 2.5.45
Date: Thu, 07 Nov 2002 13:25:05 -0500 [thread overview]
Message-ID: <3DCAB001.7020400@pobox.com> (raw)
In-Reply-To: Pine.LNX.4.44.0211011511200.14458-100000@gfrw1044.bocc.de
Jochen Friedrich wrote:
> - if (tms_isa_probe(dev))
> + if (!tms_isa_probe(dev))
> {
> - unregister_netdev(dev);
> - kfree(dev);
> - }
> - else
> num++;
> + dev = init_trdev(NULL, 0);
> + if (!dev)
> + return (0);
you still haven't address my comments from the last time you posted
this: twice you add code like the above that bails out, without
cleaning up any prior instances of this network card. For example if
card #2 fails to register but cards #0 and #1 are registered and probed
successfully, you have problems...
prev parent reply other threads:[~2002-11-07 18:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-01 14:16 [PATCH] Update of tms380tr / tmsisa for 2.5.45 Jochen Friedrich
2002-11-07 18:25 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DCAB001.7020400@pobox.com \
--to=jgarzik@pobox.com \
--cc=jochen@scram.de \
--cc=linux-kernel@vger.kernel.org \
--cc=phillim2@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.