From: Holger Waechtler <holger@convergence.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: torvalds@transmeta.com, alan@lxorguk.ukuu.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: Switch DVB to generic crc32.
Date: Fri, 08 Nov 2002 14:57:55 +0100 [thread overview]
Message-ID: <3DCBC2E3.5040503@convergence.de> (raw)
In-Reply-To: 28280.1036753951@passion.cambridge.redhat.com
David Woodhouse wrote:
> Not entirely sure why the DVB core code has its own crc32 table -- not only
> should it be using the one the kernel provides, but AFAICT nothing in the
> tree actually seem to _use_ its dvb_set_crc32() function anyway.
the crc32 table was defined because the same driver works for 2.4
kernels, there we need our own crc32 implementation. I'll check if we
can use the generic code in the kernel and then move the dvb_crc32 code
into the 2.4 compatibility file compat.c
That the crc32 check is currently not called by the software
demultiplexer is a known bug, it's already fixed in local CVS and will
get into the kernel with the next patchset. I'm currently preparing this
patchset but want to test it a little more.
Alan: do you have doubts or is there a reason not to apply the last
patchset I sent you on Tue, 29 Oct 2002? (well - it was kind of huge,
but all the namespace fixes and cleanups should justify the patch's
size, not?)
Holger
next prev parent reply other threads:[~2002-11-08 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-08 11:12 Switch DVB to generic crc32 David Woodhouse
2002-11-08 13:57 ` Holger Waechtler [this message]
2002-11-08 14:14 ` David Woodhouse
2002-11-08 15:21 ` Holger Waechtler
2002-11-08 15:25 ` David Woodhouse
2002-11-08 16:21 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DCBC2E3.5040503@convergence.de \
--to=holger@convergence.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.