Re: [PATCH] scsi_debug 1.64 , remove detect(), "hotplug" hosts

[Douglas Gilbert <dougg@torque.net>]

[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

Mike Anderson wrote:
> Douglas Gilbert [dougg@torque.net] wrote:
> 
<snip/>
> 
>>  - rmmod and subsequent modprobe's on scsi_debug
>>    sometimes blow up.
>>    Hopefully Patrick's fix (not in bk3?) addresses that.
> 
> 
> I would use the changes that Patrick sent out as we had problems
> with insmod / rmmod without these. I previously sent these to Mochel,
> but he was in the process of moving and they probably will not show up
> in a bk ( or fixes like these) until he can respond.
> 
> It seemed when I was re-working my patches that num_hosts_present is
> used during scsi_debug_exit to cleanup, but is not incremented during
> sdebug_add_host_write. There seems to a mixed use of scsi_debug_add_host
> and num_hosts_present.

Mike,
I have cleaned up that problem and a new version of
scsi_debug 1.64 is attached (applies against
2.5.46-bk3 (or the last version of 1.63 that I sent
a week ago)).
The second attachment is the changes to scsi_debug.c
since the start of this thread.

This version has been tested against a kernel with Patrick's
two patches for modprobe/rmmod stability that were sent to
this list last week. [One modifies sysfs source and the
other changes scsi_scan.c] In this environment I tried about
20 or more sequences of modprobe/rmmod on scsi_debug without
problems. Also using scsi_debug_add_host to add and remove
hosts caused no problems.

Doug Gilbert

[-- Attachment #2: scsi_debug_164_46bk3.diff.gz --]
[-- Type: application/x-gzip, Size: 4120 bytes --]

[-- Attachment #3: scsi_debug_164_inc.diff.gz --]
[-- Type: application/x-gzip, Size: 1463 bytes --]