From mboxrd@z Thu Jan  1 00:00:00 1970
Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 13 Nov 2002 17:43:18 +0100 (CET)
Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:23312 "EHLO
	www.linux.org.uk") by linux-mips.org with ESMTP id <S1123954AbSKMQnR>;
	Wed, 13 Nov 2002 17:43:17 +0100
Received: from nat-pool-rdu.redhat.com ([66.187.233.200] helo=pobox.com)
	by www.linux.org.uk with esmtp (Exim 3.33 #5)
	id 18C0ba-0007Dy-00; Wed, 13 Nov 2002 16:43:06 +0000
Message-ID: <3DD280FB.7070907@pobox.com>
Date: Wed, 13 Nov 2002 11:42:35 -0500
From: Jeff Garzik <jgarzik@pobox.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20021018
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Carsten Langgaard <carstenl@mips.com>
CC: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org,
	tsbogend@alpha.franken.de, linux-net@vger.kernel.org,
	kevink@mips.com
Subject: Re: BUG in the PCNET32 ethernet driver
References: <3DD254F8.14DE20EA@mips.com>
In-Reply-To: <3DD254F8.14DE20EA@mips.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Return-Path: <jgarzik@pobox.com>
X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0)
X-Orcpt: rfc822;linux-mips@linux-mips.org
Original-Recipient: rfc822;linux-mips@linux-mips.org
X-archive-position: 630
X-ecartis-version: Ecartis v1.0.0
Sender: linux-mips-bounce@linux-mips.org
Errors-to: linux-mips-bounce@linux-mips.org
X-original-sender: jgarzik@pobox.com
Precedence: bulk
X-list: linux-mips

Carsten Langgaard wrote:

> @@ -1316,13 +1316,13 @@
>  		    if ((newskb = dev_alloc_skb (PKT_BUF_SZ))) {
>  			skb_reserve (newskb, 2);
>  			skb = lp->rx_skbuff[entry];
> -			pci_unmap_single(lp->pci_dev, lp->rx_dma_addr[entry], skb->len, 
> PCI_DMA_FROMDEVICE);
> +			pci_unmap_single(lp->pci_dev, lp->rx_dma_addr[entry], pkt_len +2, 
> PCI_DMA_FROMDEVICE);
>  			skb_put (skb, pkt_len);
>  			lp->rx_skbuff[entry] = newskb;


Why does this line not reference PKT_BUF_SZ when all the others do?