All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>
Subject: Re: [PATCH] early printk for x86
Date: Thu, 14 Nov 2002 18:17:06 -0500	[thread overview]
Message-ID: <3DD42EF2.2070902@pobox.com> (raw)
In-Reply-To: <3DD3FCB3.40506@us.ibm.com>

Looks pretty decent to me...  minor comments:

* might be a good idea to match defaults with the defaults of the normal 
serial console.  IIRC that's 38400,N,8,1.  which brings up a tangent, 
57600 or 115200 is probably preferred these days, but that requires a 
later patch to update serial console and early serial console to be faster

* VGA base might want to be a variable, though I have not convinced 
myself that such is useful


  parent reply	other threads:[~2002-11-14 23:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-14 19:42 [PATCH] early printk for x86 Dave Hansen
2002-11-14 19:55 ` Andi Kleen
2002-11-14 20:27 ` Jeff Garzik
2002-11-14 22:50   ` Dave Hansen
2002-11-15  3:43     ` Andi Kleen
2002-11-15  3:52       ` William Lee Irwin III
2002-11-15  4:15       ` H. Peter Anvin
2002-11-14 21:05 ` Jeff Garzik
2002-11-14 23:17 ` Jeff Garzik [this message]
2002-11-18 15:15 ` David Woodhouse
2002-11-18 15:17   ` Andi Kleen
2002-11-18 15:39     ` David Woodhouse
     [not found] <3DD3FCB3.40506@us.ibm.com.suse.lists.linux.kernel>
     [not found] ` <3DD40719.5030108@pobox.com.suse.lists.linux.kernel>
     [not found]   ` <3DD428C3.4030700@us.ibm.com.suse.lists.linux.kernel>
     [not found]     ` <20021115044300.C20764@wotan.suse.de.suse.lists.linux.kernel>
     [not found]       ` <ar1sdm$gfe$1@cesium.transmeta.com.suse.lists.linux.kernel>
2002-11-15  4:31         ` Andi Kleen
2002-11-15  4:33           ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DD42EF2.2070902@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=ak@suse.de \
    --cc=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.