From: Jeff Garzik <jgarzik@pobox.com>
To: Peter Chubb <peter@chubb.wattle.id.au>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] Tulip driver fails to link (2.5.48)
Date: Mon, 18 Nov 2002 17:02:00 -0500 [thread overview]
Message-ID: <3DD96358.6050701@pobox.com> (raw)
In-Reply-To: <15833.24514.280850.81268@wombat.chubb.wattle.id.au>
Peter Chubb wrote:
> Hi,
> In the tulip driver, the .remove entry of struct pci_driveris
> declared __devexit_p but the function is declared __exit. This
> causes a relocation error when building as a built-in (not a module),
> when CONFIG_HOTPLUG is defined.
Yes... alan snuck that __devexit_p usage in there ;-)
We need to create __exit_p as the #warning indicates, because this
driver does not support CONFIG_HOTPLUG intentionally. For now, I think
it is better to add #ifdef MODULE to the driver in struct pci_driver
definition, because using "__devexit" as in your patch is incorrect.
So if you wanted to submit the patch changing __devexit_p to #ifdef
MODULE, that could probably be applied...
Jeff
prev parent reply other threads:[~2002-11-18 21:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-18 21:46 [PATCH] Tulip driver fails to link (2.5.48) Peter Chubb
2002-11-18 22:02 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DD96358.6050701@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@chubb.wattle.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.