All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <haveblue@us.ibm.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH] export e820 table on x86
Date: Thu, 21 Nov 2002 15:46:47 -0800	[thread overview]
Message-ID: <3DDD7067.6090500@us.ibm.com> (raw)
In-Reply-To: Pine.LNX.4.44.0211211448460.5779-100000@penguin.transmeta.com

Linus Torvalds wrote:
> On Wed, 20 Nov 2002, Dave Hansen wrote:
> 
>>I stole a patch that Arjan did a while ago, and ported it up to 2.5:
>>http://www.kernelnewbies.org/kernels/rh80/SOURCES/linux-2.4.0-e820.patch
>>
>>We need this so avoid making BIOS calls when using kexec.
> 
>  - why isn't the info in /proc/iomem good enough - ie wouldn't it be 
>    better to just extend resource handling to 64 bit instead of
>    creating a new file.

It looks good enough.  The only irritating part is turning the "S3 
Inc. Trio 64 3D" or "ACPI Tables" back into the numberic e820 type.  I 
accomplished this in the previous patch by removing the printing of 
the name completely.  I thought it was silly to have the kernel 
printing out a pretty name just to have the userspace program parse it 
back into a number.  It saved a bug hunk of code in both the kernel 
and the kexec utility to skip the name.

What would you think of just adding another field to /proc/iomem which 
contains the e820 field type?  I've never seen any userspace use of 
iomem, but I would imagine that things like kudzu use it.  I wonder if 
they'll get tripped up if
50000000-50000fff : Texas Instruments PCI1450
changes into something like
50000000-50000fff : 2 : Texas Instruments PCI1450

>  - please use the seq_file interfaces for new files if you do end up 
>    creating new files.

I posted one this morning.

-- 
Dave Hansen
haveblue@us.ibm.com


  reply	other threads:[~2002-11-21 23:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-21  2:00 [PATCH] export e820 table on x86 Dave Hansen
2002-11-21  2:09 ` Christoph Hellwig
2002-11-21 21:01   ` Dave Hansen
2002-11-21 22:50 ` Linus Torvalds
2002-11-21 23:46   ` Dave Hansen [this message]
2002-11-22  0:04     ` Linus Torvalds
2002-11-22  0:53       ` H. Peter Anvin
2002-11-22  6:20       ` Eric W. Biederman
2002-11-22  7:50       ` Dave Hansen
2002-11-22  8:00         ` Linus Torvalds
2002-11-22 17:17           ` Eric W. Biederman
2002-11-22 22:37             ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DDD7067.6090500@us.ibm.com \
    --to=haveblue@us.ibm.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.