All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Piet/Pete Delaney <piet@www.piet.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: aic7xxx driver potentially sleeping with spin lock held in  linux-2.5.48 (mm1 patch)
Date: Mon, 25 Nov 2002 11:29:24 -0800	[thread overview]
Message-ID: <3DE27A14.598EB80D@digeo.com> (raw)
In-Reply-To: 20021125123219.GA3103@www.piet.net

Piet/Pete Delaney wrote:
> 
> I'm getting a scsi problem in the  aic7xxx driver sleeping while the preempt_count() != 0.
> Looks like we are holding a spinlock where the slab allocator could go to sleep.
> 
> ...
> #5  0xc029104d in aic7xxx_alloc_aic_dev (p=0xc3f7d56c, SDptr=0xc3ed3c00) at drivers/scsi/aic7xxx_old.c:6636

This does an GFP_KERNEL allocation

> #6  0xc029717d in aic7xxx_queue (cmd=0xc3efca00, fn=0xc0280f04 <scsi_done>) at drivers/scsi/aic7xxx_old.c:10341
> #7  0xc0280a26 in scsi_dispatch_cmd (SCpnt=0xc3efca00) at drivers/scsi/scsi.c:852                                <--- spin lock grabed at Line 851 just prior to call to queuecommand()

OK.

> #8  0xc0285ed2 in scsi_request_fn (q=0xc3ed3c28) at drivers/scsi/scsi_lib.c:1061
> #9  0xc0253715 in blk_insert_request (q=0xc3ed3c28, rq=0xc3efc88c, at_head=0, data=0xc3efc800) at drivers/block/ll_rw_blk.c:1456

And this took the queue lock.

It's aic7xxx_old.c.   Presumably it is headed for the scrap
heap.  The allocation is a once-off startup thing.  Probably
not worth worrying about.

      reply	other threads:[~2002-11-25 19:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-25 12:32 aic7xxx driver potentially sleeping with spin lock held in linux-2.5.48 (mm1 patch) Piet/Pete Delaney
2002-11-25 19:29 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DE27A14.598EB80D@digeo.com \
    --to=akpm@digeo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=piet@www.piet.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.