[CHECKER] 5 additional buffer overruns in 2.5.48

[CHECKER] 5 additional buffer overruns in 2.5.48

[Andy Chou]

Here are 6 additional potential buffer overruns in 2.4.58.  Again, we 
would appreciate feedback on whether these are really errors or not.

-Andy


---------------------------------------------------------
[BUG] Forgot to malloc?
/u1/acc/linux/2.5.48/fs/cifs/cifssmb.c:233:CIFSSMBLogoff: 
ERROR:BUFFER:233:233:Deref uninitialized pointer pSMB
	if (atomic_read(&ses->inUse) > 0) {
		up(&ses->sesSem);
		return -EBUSY;
	}
    if(ses->secMode & (SECMODE_SIGN_REQUIRED | SECMODE_SIGN_ENABLED))

Error --->
        pSMB->hdr.Flags2 |= SMBFLG2_SECURITY_SIGNATURE;
	rc = smb_init(SMB_COM_LOGOFF_ANDX, 2, 0 /* no tcon anymore */ ,
		      (void **) &pSMB, (void **) &smb_buffer_response);
	if (rc) {
---------------------------------------------------------
[BUG] [GEM] base starts at offset 4 of buf
/u1/acc/linux/2.5.48/drivers/cdrom/cdrom.c:1170:dvd_read_physical: 
ERROR:BUFFER:1170:1170:Array bounds error: base[16] indexed with [16]
	layer->track_density = base[3] & 0xf;
	layer->linear_density = base[3] >> 4;
	layer->start_sector = base[5] << 16 | base[6] << 8 | base[7];
	layer->end_sector = base[9] << 16 | base[10] << 8 | base[11];
	layer->end_sector_l0 = base[13] << 16 | base[14] << 8 | base[15];

Error --->
	layer->bca = base[16] >> 7;

	return 0;
}
---------------------------------------------------------
[BUG] Probably forgot to malloc in first branch.
/u1/acc/linux/2.5.48/drivers/video/sstfb.c:795:sstfb_get_fix: 
ERROR:BUFFER:795:795:Deref uninitialized pointer var
	fix->visual      = FB_VISUAL_TRUECOLOR;
	/*
	 *   According to the specs, the linelength must be of 1024 
*pixels*.
	 * and the 24bpp mode is in fact a 32 bpp mode.
	 */

Error --->
	fix->line_length = (var->bits_per_pixel == 16) ? 2048 : 4096 ;
	return 0;
#undef sst_info
}
---------------------------------------------------------
[BUG] Complex.
/u1/acc/linux/2.5.48/drivers/net/sunhme.c:3218:happy_meal_pci_init: 
ERROR:BUFFER:3218:3218:Array bounds error: qp->happy_meals[4] indexed with 
[-1]
err_out_free_res:
	pci_release_regions(pdev);

err_out_clear_quattro:
	if (qp != NULL)

Error --->
		qp->happy_meals[qfe_slot] = NULL;

	kfree(dev);

---------------------------------------------------------
[BUG]
/u1/acc/linux/2.5.48/drivers/net/ni52.c:1133:ni52_timeout: 
ERROR:BUFFER:1133:1133:Array bounds error: p->xmit_cmds[1] indexed with 
[1]
	}
#endif
	{
#ifdef DEBUG
		printk("%s: xmitter timed out, try to restart! stat: 
%02x\n",dev->name,p->scb->cus);

Error --->
		printk("%s: command-stats: %04x 
%04x\n",dev->name,p->xmit_cmds[0]->cmd_status,p->xmit_cmds[1]->cmd_status);
		printk("%s: check, whether you set the right interrupt 
number!\n",dev->name);
#endif
		ni52_close(dev);

---------------------------------------------------------
[BUG]
/u1/acc/linux/2.5.48/drivers/net/3c523.c:1102:elmc_timeout: 
ERROR:BUFFER:1102:1102:Array bounds error: p->xmit_cmds[1] indexed with 
[1]

		WAIT_4_SCB_CMD();
		netif_wake_queue(dev);
	} else {
#ifdef DEBUG
		printk("%s: xmitter timed out, try to restart! stat: 
%04x\n", dev->name, p->scb->status);

Error --->
		printk("%s: command-stats: %04x %04x\n", dev->name, 
p->xmit_cmds[0]->cmd_status, p->xmit_cmds[1]->cmd_status);
#endif
		elmc_close(dev);
		elmc_open(dev);

Re: [CHECKER] 5 additional buffer overruns in 2.5.48

[Jens Axboe]

On Sat, Nov 23 2002, Andy Chou wrote:
> ---------------------------------------------------------
> [BUG] [GEM] base starts at offset 4 of buf
> /u1/acc/linux/2.5.48/drivers/cdrom/cdrom.c:1170:dvd_read_physical: 
> ERROR:BUFFER:1170:1170:Array bounds error: base[16] indexed with [16]
> 	layer->track_density = base[3] & 0xf;
> 	layer->linear_density = base[3] >> 4;
> 	layer->start_sector = base[5] << 16 | base[6] << 8 | base[7];
> 	layer->end_sector = base[9] << 16 | base[10] << 8 | base[11];
> 	layer->end_sector_l0 = base[13] << 16 | base[14] << 8 | base[15];
> 
> Error --->
> 	layer->bca = base[16] >> 7;
> 
> 	return 0;

Ah good catch. The buf[20] is simply too small, it must be 21 (or
probably just 22 to make it even, the size is 21 bytes for header and
data)

-- 
Jens Axboe

Re: [CHECKER] 5 additional buffer overruns in 2.5.48

[Jeff Garzik]

Andy Chou wrote:
> Here are 6 additional potential buffer overruns in 2.4.58.  Again, we 
> would appreciate feedback on whether these are really errors or not.
> 
> -Andy
> 
> 
> ---------------------------------------------------------
> [BUG] Forgot to malloc?
> /u1/acc/linux/2.5.48/fs/cifs/cifssmb.c:233:CIFSSMBLogoff: 
> ERROR:BUFFER:233:233:Deref uninitialized pointer pSMB
> 	if (atomic_read(&ses->inUse) > 0) {
> 		up(&ses->sesSem);
> 		return -EBUSY;
> 	}
>     if(ses->secMode & (SECMODE_SIGN_REQUIRED | SECMODE_SIGN_ENABLED))
> 
> Error --->
>         pSMB->hdr.Flags2 |= SMBFLG2_SECURITY_SIGNATURE;
> 	rc = smb_init(SMB_COM_LOGOFF_ANDX, 2, 0 /* no tcon anymore */ ,
> 		      (void **) &pSMB, (void **) &smb_buffer_response);
> 	if (rc) {
> ---------------------------------------------------------
> [BUG] [GEM] base starts at offset 4 of buf
> /u1/acc/linux/2.5.48/drivers/cdrom/cdrom.c:1170:dvd_read_physical: 
> ERROR:BUFFER:1170:1170:Array bounds error: base[16] indexed with [16]
> 	layer->track_density = base[3] & 0xf;
> 	layer->linear_density = base[3] >> 4;
> 	layer->start_sector = base[5] << 16 | base[6] << 8 | base[7];
> 	layer->end_sector = base[9] << 16 | base[10] << 8 | base[11];
> 	layer->end_sector_l0 = base[13] << 16 | base[14] << 8 | base[15];
> 
> Error --->
> 	layer->bca = base[16] >> 7;
> 
> 	return 0;
> }
> ---------------------------------------------------------
> [BUG] Probably forgot to malloc in first branch.
> /u1/acc/linux/2.5.48/drivers/video/sstfb.c:795:sstfb_get_fix: 
> ERROR:BUFFER:795:795:Deref uninitialized pointer var
> 	fix->visual      = FB_VISUAL_TRUECOLOR;
> 	/*
> 	 *   According to the specs, the linelength must be of 1024 
> *pixels*.
> 	 * and the 24bpp mode is in fact a 32 bpp mode.
> 	 */
> 
> Error --->
> 	fix->line_length = (var->bits_per_pixel == 16) ? 2048 : 4096 ;
> 	return 0;
> #undef sst_info
> }
> ---------------------------------------------------------
> [BUG] Complex.
> /u1/acc/linux/2.5.48/drivers/net/sunhme.c:3218:happy_meal_pci_init: 
> ERROR:BUFFER:3218:3218:Array bounds error: qp->happy_meals[4] indexed with 
> [-1]
> err_out_free_res:
> 	pci_release_regions(pdev);
> 
> err_out_clear_quattro:
> 	if (qp != NULL)
> 
> Error --->
> 		qp->happy_meals[qfe_slot] = NULL;
> 

notabug, qfe_slot is clearly initialized to zero before this code is hit.


> ---------------------------------------------------------
> [BUG]
> /u1/acc/linux/2.5.48/drivers/net/ni52.c:1133:ni52_timeout: 
> ERROR:BUFFER:1133:1133:Array bounds error: p->xmit_cmds[1] indexed with 
> [1]

bug, fixed.

> ---------------------------------------------------------
> [BUG]
> /u1/acc/linux/2.5.48/drivers/net/3c523.c:1102:elmc_timeout: 
> ERROR:BUFFER:1102:1102:Array bounds error: p->xmit_cmds[1] indexed with 
> [1]

bug, fixed.