Re: [PATCH] 2.5.x write_super is not for syncing

[Andrew Morton <akpm@digeo.com>]

Bryan Henderson wrote:
> 
> >The intent is that ->sync_fs() should only be
> >called for sync, unmount, etc.
> 
> Why unmount, etc.?  That's just more assumption-making by FS as to what
> these operations require for every filesystem type.
> 
> unmount, which in general requires a rather different kind of syncing than
> sync(), already has its own VFS call.
> I don't know what etc. would be but it's probably also something a
> filesystem driver might want to distinguish from sync().

Well, I'd say that telling the fs about umount activity is "out
of scope" for this exercise ;)

It seems reasonable to have a super_op which says "sync everything
to disk".  And to call that in response to /bin/sync and unmount.

Doesn't it?