Linus, For a small bit of sanity and a savings of 9 lines of code, we should be including the generic topology macros in the alpha & ppc64 topology files, rather than just redefining them. It is much easier to keep all the generic topology macros in sync this way, too. Cheers! -Matt [mcd@arrakis patches]$ diffstat use_generic_topo-2.5.50.patch asm-alpha/topology.h | 19 +++++++------------ asm-ppc64/topology.h | 8 ++------ 2 files changed, 9 insertions(+), 18 deletions(-)