From: Patrick McHardy <kaber@trash.net>
To: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Cc: netdev@oss.sgi.com
Subject: [PATCH]: forgotten dev_put for bridge-devices in nf_reinject
Date: Tue, 10 Dec 2002 14:35:58 +0100 [thread overview]
Message-ID: <3DF5EDBE.7000707@trash.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
Hi.
The attached patch releases the bridge devices grabbed in nf_queue after
reinjecting the packet.
Seems someone forgot these (or planned to get Rusty killed) ;)
Bye,
Patrick
[-- Attachment #2: nfqueue-bridge-devput.diff --]
[-- Type: text/plain, Size: 601 bytes --]
--- linux-2.5.50/net/core/netfilter.c.orig 2002-12-10 14:16:20.000000000 +0100
+++ linux-2.5.50/net/core/netfilter.c 2002-12-10 14:19:23.000000000 +0100
@@ -574,7 +574,15 @@
/* Release those devices we held, or Alexey will kill me. */
if (info->indev) dev_put(info->indev);
if (info->outdev) dev_put(info->outdev);
-
+#if defined(CONFIG_BRIDGE) || defined(CONFIG_BRIDGE_MODULE)
+ if (skb->nf_bridge) {
+ if (skb->nf_bridge->physindev)
+ dev_put(skb->nf_bridge->physindev);
+ if (skb->nf_bridge->physoutdev)
+ dev_put(skb->nf_bridge->physoutdev);
+ }
+#endif
+
kfree(info);
return;
}
reply other threads:[~2002-12-10 13:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DF5EDBE.7000707@trash.net \
--to=kaber@trash.net \
--cc=netdev@oss.sgi.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.