Re: ECN target bug report

[Andrea Rossato <mailing_list@istitutocolli.org>]

Patrick McHardy wrote:
> I thought calculating checksum for x and htons(x) should give me same 
> result, obiously that is wrong (which i learned after trying it out).
> For the first patch: *tcpflags are bitfields (position declared 
> dependant of endianess), so no htons here.
> For the second patch, it's working with or without, although i think the 
> correct way is with the patch:
> 
> u_int16_t diffs[2];
> diffs[0] = htons(iph->tos) ^ 0xFFFF;
> ...
> diffs[1] = htons(iph->tos);
> ...
> 
> iph->tos is of type u_int8_t. so no htons is necessary.


I know netiquette suggest not to send messages just to thank...but i 
spet the whole afternoon trying to understand when exactly host-to-net 
byte order translation was needed without results!
Now I've got it!!
Thanks,
andrea