From: Andrew Morton <akpm@digeo.com>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: lkml <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: Re: 2.5.52-mm2
Date: Thu, 19 Dec 2002 02:31:32 -0800 [thread overview]
Message-ID: <3E01A004.58F2B880@digeo.com> (raw)
In-Reply-To: 20021219101219.GS31800@holomorphy.com
William Lee Irwin III wrote:
>
> On Wed, Dec 18, 2002 at 09:53:18PM -0800, Andrew Morton wrote:
> >>> url: http://www.zip.com.au/~akpm/linux/patches/2.5/2.5.52/2.5.52-mm2/
>
> On Thu, Dec 19, 2002 at 12:54:26AM -0800, William Lee Irwin III wrote:
> >> Kernel compile on ramfs, shpte off, overcommit on (probably more like a
> >> stress test for shpte):
>
> On Thu, Dec 19, 2002 at 01:28:53AM -0800, William Lee Irwin III wrote:
> > With shpte on:
>
> With the following patch:
>
> c013d4d4 94944 0.310788 zap_pte_range
> c01355d0 104773 0.342962 nr_free_pages
> c014f65c 107566 0.352105 __fput
> c01b1750 112055 0.366799 __copy_user_intel
> c0115350 121040 0.39621 smp_apic_timer_interrupt
> c0119814 126089 0.412738 kmap_atomic
> c014b6cc 145095 0.474952 pte_unshare
> c01fb11c 145992 0.477888 sync_buffer
> c0122a78 148079 0.484719 current_kernel_time
> c01168b8 193805 0.634398 x86_profile_hook
> c013f140 205233 0.671806 do_no_page
> c0164aac 235356 0.77041 d_lookup
> c01b18f8 257358 0.842431 __copy_from_user
> c0131f7c 275559 0.90201 find_get_page
> c011a560 282341 0.92421 scheduler_tick
> c0140090 300128 0.982434 vm_enough_memory
> c013f4bc 310474 1.0163 handle_mm_fault
> c014f3d0 312725 1.02367 get_empty_filp
> c011a0a8 365066 1.195 load_balance
> c014f9e9 502737 1.64565 .text.lock.file_table
> c01b1890 719105 2.35391 __copy_to_user
> c0135768 911894 2.98498 __get_page_state
> c013ee50 952823 3.11895 do_anonymous_page
> c01436d0 1079864 3.53481 page_add_rmap
> c01438cc 1186938 3.8853 page_remove_rmap
> c0106f38 17763755 58.1476 poll_idle
Is that improved?
> pfn_to_nid() got lots of icache misses. Try using a macro.
What's the callsite?
Actually, just looking at mmzone.h, I have to say "ick". The
non-NUMA case seems unnecessarily overdone. eg:
#define page_to_pfn(page)
((page - page_zone(page)->zone_mem_map) + page_zone(page)->zone_start_pfn)
Ouch. Why can't we have the good old `page - mem_map' here?
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@digeo.com>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: lkml <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: Re: 2.5.52-mm2
Date: Thu, 19 Dec 2002 02:31:32 -0800 [thread overview]
Message-ID: <3E01A004.58F2B880@digeo.com> (raw)
In-Reply-To: 20021219101219.GS31800@holomorphy.com
William Lee Irwin III wrote:
>
> On Wed, Dec 18, 2002 at 09:53:18PM -0800, Andrew Morton wrote:
> >>> url: http://www.zip.com.au/~akpm/linux/patches/2.5/2.5.52/2.5.52-mm2/
>
> On Thu, Dec 19, 2002 at 12:54:26AM -0800, William Lee Irwin III wrote:
> >> Kernel compile on ramfs, shpte off, overcommit on (probably more like a
> >> stress test for shpte):
>
> On Thu, Dec 19, 2002 at 01:28:53AM -0800, William Lee Irwin III wrote:
> > With shpte on:
>
> With the following patch:
>
> c013d4d4 94944 0.310788 zap_pte_range
> c01355d0 104773 0.342962 nr_free_pages
> c014f65c 107566 0.352105 __fput
> c01b1750 112055 0.366799 __copy_user_intel
> c0115350 121040 0.39621 smp_apic_timer_interrupt
> c0119814 126089 0.412738 kmap_atomic
> c014b6cc 145095 0.474952 pte_unshare
> c01fb11c 145992 0.477888 sync_buffer
> c0122a78 148079 0.484719 current_kernel_time
> c01168b8 193805 0.634398 x86_profile_hook
> c013f140 205233 0.671806 do_no_page
> c0164aac 235356 0.77041 d_lookup
> c01b18f8 257358 0.842431 __copy_from_user
> c0131f7c 275559 0.90201 find_get_page
> c011a560 282341 0.92421 scheduler_tick
> c0140090 300128 0.982434 vm_enough_memory
> c013f4bc 310474 1.0163 handle_mm_fault
> c014f3d0 312725 1.02367 get_empty_filp
> c011a0a8 365066 1.195 load_balance
> c014f9e9 502737 1.64565 .text.lock.file_table
> c01b1890 719105 2.35391 __copy_to_user
> c0135768 911894 2.98498 __get_page_state
> c013ee50 952823 3.11895 do_anonymous_page
> c01436d0 1079864 3.53481 page_add_rmap
> c01438cc 1186938 3.8853 page_remove_rmap
> c0106f38 17763755 58.1476 poll_idle
Is that improved?
> pfn_to_nid() got lots of icache misses. Try using a macro.
What's the callsite?
Actually, just looking at mmzone.h, I have to say "ick". The
non-NUMA case seems unnecessarily overdone. eg:
#define page_to_pfn(page)
((page - page_zone(page)->zone_mem_map) + page_zone(page)->zone_start_pfn)
Ouch. Why can't we have the good old `page - mem_map' here?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-12-19 10:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-19 5:53 2.5.52-mm2 Andrew Morton
2002-12-19 5:53 ` 2.5.52-mm2 Andrew Morton
2002-12-19 8:54 ` 2.5.52-mm2 William Lee Irwin III
2002-12-19 8:54 ` 2.5.52-mm2 William Lee Irwin III
2002-12-19 9:28 ` 2.5.52-mm2 William Lee Irwin III
2002-12-19 9:28 ` 2.5.52-mm2 William Lee Irwin III
2002-12-19 10:12 ` 2.5.52-mm2 William Lee Irwin III
2002-12-19 10:12 ` 2.5.52-mm2 William Lee Irwin III
2002-12-19 10:31 ` Andrew Morton [this message]
2002-12-19 10:31 ` 2.5.52-mm2 Andrew Morton
2002-12-19 10:51 ` 2.5.52-mm2 William Lee Irwin III
2002-12-19 10:51 ` 2.5.52-mm2 William Lee Irwin III
2002-12-19 15:22 ` 2.5.52-mm2 Martin J. Bligh
2002-12-19 15:22 ` 2.5.52-mm2 Martin J. Bligh
2002-12-19 9:41 ` 2.5.52-mm2 Andrew Morton
2002-12-19 9:41 ` 2.5.52-mm2 Andrew Morton
2002-12-19 9:50 ` 2.5.52-mm2 Andrew Morton
2002-12-19 9:50 ` 2.5.52-mm2 Andrew Morton
2002-12-19 17:02 ` mremap use-after-free [was Re: 2.5.52-mm2] Hugh Dickins
2002-12-19 17:02 ` Hugh Dickins
2002-12-19 18:18 ` Andrew Morton
2002-12-19 18:18 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E01A004.58F2B880@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.